Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update continuous data flagging #549

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update continuous data flagging #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/ResultFlagsIndependent.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,8 @@ TADA_FlagContinuousData <- function(.data, clean = FALSE, flaggedonly = FALSE, t

if (length(noncont.data) >= 1) {
info_match <- noncont.data %>%
# remove quality control samples
dplyr::filter(!grepl("Quality Control", ActivityTypeCode)) %>%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few ActivityTypeCode's that do not include "Quality Control" that are also QC samples. Could you reference the internal TADA package WQXActivityTypeRef here instead and keep only the results assigned by TADA as "Non_QC"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - that is a better, more specific solution. I can make that change.

dplyr::group_by(
TADA.LatitudeMeasure, TADA.LongitudeMeasure,
OrganizationIdentifier, TADA.ComparableDataIdentifier,
Expand Down
Loading