Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#346 - Add tribal boundaries to overview map #405

Merged
merged 12 commits into from
Feb 22, 2024
Merged

#346 - Add tribal boundaries to overview map #405

merged 12 commits into from
Feb 22, 2024

Conversation

renaemyers
Copy link
Collaborator

Tribal layers will load by default in the overview map, restricted by the bounding box of the current dataset. They can be toggled on and off using a button (all layers work together and can't be turned on/off individually). Colors and icons are as discussed previously (orange/tan colors and open triangle icons for points) but can be changed to match HMW if desired.

@renaemyers renaemyers linked an issue Feb 22, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 18.82845% with 194 lines in your changes are missing coverage. Please review.

Project coverage is 42.96%. Comparing base (cb2183f) to head (b351a22).

❗ Current head b351a22 differs from pull request most recent head 98d6ed2. Consider uploading reports for the commit 98d6ed2 to get more accurate results

Files Patch % Lines
R/Utilities.R 0.00% 83 Missing ⚠️
R/WQXRefTables.R 0.00% 62 Missing ⚠️
R/Filtering.R 0.00% 28 Missing ⚠️
R/Figures.R 0.00% 20 Missing ⚠️
R/RequiredCols.R 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #405      +/-   ##
===========================================
- Coverage    44.67%   42.96%   -1.72%     
===========================================
  Files           14       14              
  Lines         3201     3310     +109     
===========================================
- Hits          1430     1422       -8     
- Misses        1771     1888     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristinamullin
Copy link
Collaborator

@renaemyers In this example, if you try to click on the sites, you can't unless the tribal boundary is turned off first. Is it possible for the WQP monitoring locations to be on top of the tribal layer by default?

data(Data_6Tribes_5y_Harmonized)
TADA_OverviewMap(Data_6Tribes_5y_Harmonized)

add TADA_ prefix, update docs
add TADA to examples for functions that are not exported
@cristinamullin
Copy link
Collaborator

Updates:

  • Updated function names to match TADA convention and exported: TADA_addPoints and TADA_addPolys. I think they could be values to others on their own.
  • Added TADA::: prefix to any examples in documentation that call functions that are NOT exported.
  • Ran document()
  • Merged in updates from develop upstream

@cristinamullin cristinamullin merged commit 40a3f7b into develop Feb 22, 2024
1 of 6 checks passed
@cristinamullin cristinamullin deleted the rm_346 branch February 22, 2024 22:35
@cristinamullin cristinamullin restored the rm_346 branch February 27, 2024 15:38
@cristinamullin cristinamullin deleted the rm_346 branch February 27, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tribal boundaries to map function
3 participants