Update Utilities.R #365
Merged
Update Utilities.R #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #365 +/- ##
===========================================
+ Coverage 53.16% 53.39% +0.22%
===========================================
Files 12 12
Lines 2998 3006 +8
===========================================
+ Hits 1594 1605 +11
+ Misses 1404 1401 -3 ☔ View full report in Codecov by Sentry. |
cristinamullin
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used TADA_GetCharacteristicRef() to create a data frame and then filter for "retired" CharacteristicNames. Then modified them to be compatible with the NWIS names by removing "retired" and any characters after. These additional CharacteristicName options are then added to the original ref.table of deprecated CharacteristicNames.