Merge remote-tracking branch 'origin/fix_check_warnings' into 11.6.24…

…review-cm
USEPA · Nov 7, 2024 · 6ca123e · 6ca123e
2 parents f4232e6 + 84ea5c1
commit 6ca123e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/R/Maintenance.R b/R/Maintenance.R
@@ -295,4 +295,4 @@ FindSynonyms <- function() {
 # # More information about http response codes can be found here:
 # # [Mozilla Developer HTTP response status codes] (https://developer.mozilla.org/en-US/docs/Web/HTTP/Status)
 # # Replace the broken links with functional ones or remove if no acceptable substitute is available.
-# # Rerun code above to verify that df_false contains zero rows.
+# # Rerun code above to verify that df_false contains zero rows.
diff --git a/inst/extdata/WQXMeasureQualifierCodeRef.csv b/inst/extdata/WQXMeasureQualifierCodeRef.csv
@@ -53,6 +53,7 @@
 "Result Measure Qualifier(MeasureQualifierCode)",1168,"DOM","count >= 15 percent (dominant)","8/16/2021 11:03:38 AM","Pass"
 "Result Measure Qualifier(MeasureQualifierCode)",1001,"DT","Date value on logger was incorrect; Changed to date of sampling event; Date and Time considered suspect.","4/13/2020 7:13:06 AM","Suspect"
 "Result Measure Qualifier(MeasureQualifierCode)",54,"E","Concentration of analyte being analyzed exceeded calibration range of instrument.","2/13/2012 6:03:18 PM","Over-Detect"
+"Result Measure Qualifier(MeasureQualifierCode)",750,"EC","Analyte and the associated numerical value excluded from calculations","11/7/2024 1:10:33 PM","Not Reviewed"
 "Result Measure Qualifier(MeasureQualifierCode)",136,"ECI","Estimated Value, Coelution","3/16/2016 1:04:24 PM","Pass"
 "Result Measure Qualifier(MeasureQualifierCode)",19,"EE","Identifies compounds whose concentration exceed the calibration range addition of the instrument for that specific analysis.","8/28/2009 5:04:35 PM","Over-Detect"
 "Result Measure Qualifier(MeasureQualifierCode)",788,"EER","No Result Reported, entry error; Original value is known to be incorrect due to a data entry error.  The correct value could not be determined. No result value was reported","1/23/2020 2:12:06 PM","Suspect"

diff --git a/tests/testthat/test-URLChecker.R b/tests/testthat/test-URLChecker.R
@@ -36,7 +36,11 @@ test_that("URLs are not broken", {
     unique() %>%
     # problematic URL I can't get a response from using multiple methods (itec) and CRAN because its response is inconsistent, likely due to redirecting to mirrors (HRM 10/28/2024)
     setdiff(c(
-      "https://www.itecmembers.org/attains/"
+      # url works (HRM 11/7/24), but does not provide a recognizable response code
+      "https://www.itecmembers.org/attains/",
+      # if included will get 500 response because this is an incomplete URL 
+      # additional query information is pasted in as part of geospatial functions
+      "https://attains.epa.gov/attains-public/api/assessmentUnits?assessmentUnitIdentifier="
     ))
 
   # retrieve http response headers from url list