Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed plotrange #115

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

changed plotrange #115

wants to merge 5 commits into from

Conversation

knuppla
Copy link
Collaborator

@knuppla knuppla commented Nov 19, 2024

Changed plotrange to be dependent on minimum concentration value. Left maximum plotrange value at 100 to maintain a wide view of the plot but can be easily changed later. Added untreated control group check and pseudo transformation found in concRespPlot2.

@knuppla knuppla linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link

@Kelly-Carstens-EPA Kelly-Carstens-EPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the min/max experimental conc feature is working. I did notice that the curve was not fitting for concs below 1e-3. For example:
image

@knuppla
Copy link
Collaborator Author

knuppla commented Nov 21, 2024

I removed the hard-coding of the plotting grid points entirely. I replaced conc_plot with the provided experimental concentrations. I also compared the plot against concRespPlot2.
concRespPlot
smallConcsconcRespPlot

concRespPlot2
smallConcsconcRespPlot2

Copy link

@Kelly-Carstens-EPA Kelly-Carstens-EPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also replicated the straight line with other data. It looks like I can still get a curve but it gets dropped in some cases. Maybe @sedavid01 has an idea.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concRespPlot xlim
2 participants