handle edge cases for dicho scaled residual calculations

USEPA · Mar 10, 2023 · 607ea3f · shapiromatron · Apr 13, 2023 · cwsimmon
1 parent 8e18b10
commit 607ea3f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/code_base/dichotomous_entry_code.cpp b/src/code_base/dichotomous_entry_code.cpp
@@ -812,8 +812,11 @@ void compute_dichotomous_pearson_GOF(dichotomous_PGOF_data *data, dichotomous_PG
      Eigen::MatrixXd expected = Y.col(1).array()*mean_d.array(); 
 
      Eigen::MatrixXd residual = Y.col(0) - expected; 
-     //residual = residual.array()/sqrt(expected.array()); 
-     residual = residual.array()/sqrt(expected.array()*(1.0-mean_d.array())); //modified to match BMDS 3.2 calculation
+     //residual = residual.array()/sqrt(expected.array());
+     Eigen::MatrixXd SD = sqrt(expected.array()*(1.0-mean_d.array()));
+     std::cout<<"SD array: " << SD << std::endl;
+     residual = (SD.array() > 0.0).select(residual.array()/SD.array(), 0.0); //modified to match BMDS 3.2 calculation
+
      Eigen::MatrixXd sqresid  = residual.array()*residual.array();
      Eigen::MatrixXd resultsTable(Y.rows(),5); 
      resultsTable << Y.col(0) , Y.col(1) , expected , residual, sqresid;