Skip to content

Commit

Permalink
Created the HazardParameter enum #8
Browse files Browse the repository at this point in the history
  • Loading branch information
jackschonherr committed Aug 13, 2024
1 parent 80811fc commit cb9a15e
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions Consequences/HazardParameter.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
namespace Consequences;

This comment has been minimized.

Copy link
@HenryGeorgist

HenryGeorgist Aug 14, 2024

one thing we did not specify is how we expect you to namespace. if we have a single namespace of "consequences" it might end up getting clustered with alot of classes. I think we should consider namespacing on the project (we can do that in a later refactor) maybe we could talk about this at a future meeting.

Also, good work on tagging the issue in the commit!

I noticed this is on the "project-settings" branch which seems incongruent with the feature request. I suggest in the future to have pull requests that are logical groupings of features. For instance "initial-interfaces" or something like that.

public enum HazardParameter : long
{
NoHazard,
Depth = 2,
Velocity = 4,
ArrivalTime = 8,
ArrivalTime2ft = 16
}

0 comments on commit cb9a15e

Please sign in to comment.