Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minio testing #26

Merged
merged 12 commits into from
Jan 1, 2025
Merged

Minio testing #26

merged 12 commits into from
Jan 1, 2025

Conversation

jackschonherr
Copy link
Contributor

setting up a minio server in a container that the tests can interact with

@Brennan1994 Brennan1994 marked this pull request as ready for review November 20, 2024 20:22
Copy link
Contributor

@Brennan1994 Brennan1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get it

@@ -24,5 +24,7 @@ jobs:
run: dotnet restore
- name: Build
run: dotnet build --no-restore
# - name: Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of ubuntu branch trigger

@@ -24,5 +24,7 @@ jobs:
run: dotnet restore
- name: Build
run: dotnet build --no-restore
# - name: Test
# run: dotnet test --no-build --verbosity normal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump dotnet to 8.0.x

[Fact]
public async void ObjectLifeCycle()
{
string profileName = "KARL";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuke commented out code

public async void JackBucket()
{
string profileName = "JACK";
SetEnv(profileName + "_" + EnvironmentVariables.AWS_S3_BUCKET, "test-bucket-1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify UN and Pass

@Brennan1994 Brennan1994 merged commit ca303a8 into main Jan 1, 2025
1 check passed
@Brennan1994 Brennan1994 deleted the minio-testing branch January 1, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants