Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player attack #395

Merged
merged 13 commits into from
Oct 13, 2021
Merged

Player attack #395

merged 13 commits into from
Oct 13, 2021

Conversation

lisslulay
Copy link
Contributor

@lisslulay lisslulay commented Oct 13, 2021 •
edited
Loading

add particle effect and fix some bugs

@lisslulay lisslulay marked this pull request as draft October 13, 2021 02:46
@lisslulay lisslulay marked this pull request as ready for review October 13, 2021 06:01
yyfyyfstudy1
yyfyyfstudy1 reviewed Oct 13, 2021
View reviewed changes
Copy link
Contributor

@yyfyyfstudy1 yyfyyfstudy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good code

@lisslulay lisslulay merged commit d437aaf into main Oct 13, 2021
@lisslulay lisslulay linked an issue Oct 13, 2021 that may be closed by this pull request
Team 4 and 8 Sprint 4 Feature Ticket - Player Attack #384
Open
5 tasks
@lisslulay lisslulay removed a link to an issue Oct 13, 2021
Team 4 and 8 Sprint 4 Feature Ticket - Player Attack #384
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyfyyfstudy1 yyfyyfstudy1 yyfyyfstudy1 left review comments

Assignees
No one assigned
Labels
team-8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisslulay @yyfyyfstudy1