-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peer review #2
Open
quaintmercury
wants to merge
1
commit into
UO-CIS211:master
Choose a base branch
from
quaintmercury:peer-review
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
peer review #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you mean to make a pull request? I suspect you meant to be submitting a peer review in Canvas.
… On May 5, 2020, at 8:36 AM, quaintmercury ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#2 <#2>
Commit Summary
peer review
File Changes
A expr.py <https://github.com/UO-CIS211/calculator/pull/2/files#diff-16f1ef275ed557af8b0e53ef533a7164> (216)
M rpncalc.py <https://github.com/UO-CIS211/calculator/pull/2/files#diff-c649cb6ef70be3189f02d82967343503> (42)
Patch Links:
https://github.com/UO-CIS211/calculator/pull/2.patch <https://github.com/UO-CIS211/calculator/pull/2.patch>
https://github.com/UO-CIS211/calculator/pull/2.diff <https://github.com/UO-CIS211/calculator/pull/2.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCYIBKNYI2HZGJOC3R2CT3RQAW75ANCNFSM4MZVXRAQ>.
|
Oh shit yeah that was my mistake this morning.
…On Tue, May 5, 2020, 12:41 PM Michal Young ***@***.***> wrote:
Did you mean to make a pull request? I suspect you meant to be submitting
a peer review in Canvas.
> On May 5, 2020, at 8:36 AM, quaintmercury ***@***.***>
wrote:
>
> You can view, comment on, or merge this pull request online at:
>
> #2 <
#2>
> Commit Summary
>
> peer review
> File Changes
>
> A expr.py <
https://github.com/UO-CIS211/calculator/pull/2/files#diff-16f1ef275ed557af8b0e53ef533a7164>
(216)
> M rpncalc.py <
https://github.com/UO-CIS211/calculator/pull/2/files#diff-c649cb6ef70be3189f02d82967343503>
(42)
> Patch Links:
>
> https://github.com/UO-CIS211/calculator/pull/2.patch <
https://github.com/UO-CIS211/calculator/pull/2.patch>
> https://github.com/UO-CIS211/calculator/pull/2.diff <
https://github.com/UO-CIS211/calculator/pull/2.diff>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <
#2>, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ADCYIBKNYI2HZGJOC3R2CT3RQAW75ANCNFSM4MZVXRAQ
>.
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANPIK4BSLQSL3KTVXNDU3X3RQBTWDANCNFSM4MZVXRAQ>
.
|
It was supposed to only be on my clone of the project.
…On Tue, May 5, 2020, 12:41 PM Michal Young ***@***.***> wrote:
Did you mean to make a pull request? I suspect you meant to be submitting
a peer review in Canvas.
> On May 5, 2020, at 8:36 AM, quaintmercury ***@***.***>
wrote:
>
> You can view, comment on, or merge this pull request online at:
>
> #2 <
#2>
> Commit Summary
>
> peer review
> File Changes
>
> A expr.py <
https://github.com/UO-CIS211/calculator/pull/2/files#diff-16f1ef275ed557af8b0e53ef533a7164>
(216)
> M rpncalc.py <
https://github.com/UO-CIS211/calculator/pull/2/files#diff-c649cb6ef70be3189f02d82967343503>
(42)
> Patch Links:
>
> https://github.com/UO-CIS211/calculator/pull/2.patch <
https://github.com/UO-CIS211/calculator/pull/2.patch>
> https://github.com/UO-CIS211/calculator/pull/2.diff <
https://github.com/UO-CIS211/calculator/pull/2.diff>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <
#2>, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ADCYIBKNYI2HZGJOC3R2CT3RQAW75ANCNFSM4MZVXRAQ
>.
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANPIK4BSLQSL3KTVXNDU3X3RQBTWDANCNFSM4MZVXRAQ>
.
|
No worries. I’ll just ignore it.
Michal
… On May 5, 2020, at 12:51 PM, quaintmercury ***@***.***> wrote:
It was supposed to only be on my clone of the project.
On Tue, May 5, 2020, 12:41 PM Michal Young ***@***.***> wrote:
> Did you mean to make a pull request? I suspect you meant to be submitting
> a peer review in Canvas.
>
> > On May 5, 2020, at 8:36 AM, quaintmercury ***@***.***>
> wrote:
> >
> > You can view, comment on, or merge this pull request online at:
> >
> > #2 <
> #2>
> > Commit Summary
> >
> > peer review
> > File Changes
> >
> > A expr.py <
> https://github.com/UO-CIS211/calculator/pull/2/files#diff-16f1ef275ed557af8b0e53ef533a7164>
> (216)
> > M rpncalc.py <
> https://github.com/UO-CIS211/calculator/pull/2/files#diff-c649cb6ef70be3189f02d82967343503>
> (42)
> > Patch Links:
> >
> > https://github.com/UO-CIS211/calculator/pull/2.patch <
> https://github.com/UO-CIS211/calculator/pull/2.patch>
> > https://github.com/UO-CIS211/calculator/pull/2.diff <
> https://github.com/UO-CIS211/calculator/pull/2.diff>
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub <
> #2>, or unsubscribe <
> https://github.com/notifications/unsubscribe-auth/ADCYIBKNYI2HZGJOC3R2CT3RQAW75ANCNFSM4MZVXRAQ
> >.
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#2 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANPIK4BSLQSL3KTVXNDU3X3RQBTWDANCNFSM4MZVXRAQ>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCYIBNYKDFB3JVFDFMGRA3RQBU5TANCNFSM4MZVXRAQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.