Bxc 4416 cleanup temp files #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
approved these changes
Feb 6, 2024
bbpennel
added a commit
that referenced
this pull request
Feb 15, 2024
* Removing unused performance visualizations (#1666) * Fix display of exhibits in the UI (#1665) * Fix display of exhibits in the UI. * Fix issue with multiple exhibits not being semicolon separated, and add tests * Move exhibits below finding aid ino. Add a space when separating exhibit links * Bxc 4416 cleanup temp files (#1667) * BXC-4416 clean up temporary files * Capture the email attachment when sendEmail is called for testing purposes * BXC-4416 fix up tests --------- Co-authored-by: Sharon Luong <[email protected]> Co-authored-by: Ben Pennell <[email protected]> * Address codeclimate issues * BXC-4427 add initial files for setting view behavior * Always reload metadata (#1669) * update exhibit field label (#1673) * BXC-4427 get request object and helper started * BXC-4427 initial files and processor test * BXC-4427 start on router test * BXC-4427 making tests pass * BXC-4427 rename view behavior classes to view settings for more flexibility * BXC-4427 update javadoc to new class names --------- Co-authored-by: Dean Farrell <[email protected]> Co-authored-by: Sharon Luong <[email protected]> Co-authored-by: Ben Pennell <[email protected]> Co-authored-by: Ben Pennell <[email protected]> Co-authored-by: Anna Goslen <[email protected]>
bbpennel
added a commit
that referenced
this pull request
Mar 12, 2024
* Basic UI setup for setting page view display (#1663) * Basic UI setup for setting page view display * Basic setup of batch setting view direction. Update form to work with a work or batch of works * Update batch update paged display to submit correctly * Rename to PageSettings and remove viewing direction * Bxc 4427 view settings (#1677) * Removing unused performance visualizations (#1666) * Fix display of exhibits in the UI (#1665) * Fix display of exhibits in the UI. * Fix issue with multiple exhibits not being semicolon separated, and add tests * Move exhibits below finding aid ino. Add a space when separating exhibit links * Bxc 4416 cleanup temp files (#1667) * BXC-4416 clean up temporary files * Capture the email attachment when sendEmail is called for testing purposes * BXC-4416 fix up tests --------- Co-authored-by: Sharon Luong <[email protected]> Co-authored-by: Ben Pennell <[email protected]> * Address codeclimate issues * BXC-4427 add initial files for setting view behavior * Always reload metadata (#1669) * update exhibit field label (#1673) * BXC-4427 get request object and helper started * BXC-4427 initial files and processor test * BXC-4427 start on router test * BXC-4427 making tests pass * BXC-4427 rename view behavior classes to view settings for more flexibility * BXC-4427 update javadoc to new class names --------- Co-authored-by: Dean Farrell <[email protected]> Co-authored-by: Sharon Luong <[email protected]> Co-authored-by: Ben Pennell <[email protected]> Co-authored-by: Ben Pennell <[email protected]> Co-authored-by: Anna Goslen <[email protected]> * Bxc 4435 add permission (#1678) * BXC-4435 add new view settings permission and assign it to a user role * BXC-4435 update terminology --------- Co-authored-by: Sharon Luong <[email protected]> * BXC-4430 add controller file * BXC-4430 finishing up endpoint and starting on test * BXC-4430 working on tests * BXC-4430 finish tests * BXC-4430 add javadocs and a bit of cleanup * Bxc 4429 update view setting endpoint (#1686) * BXC-4429 finish up controller and tests * BXC-4429 update front end to match back end * BXC-4429 clean up code, add new tests * BXC-4429 use string utils is blank * BXC-4429 update based on PR comments * BXC-4429 add view request sender bean * BXC-4429 update batch settings url * BXC-4429 update param from view_setting to behavior * BXC-4429 set agent on the view setting request * BXC-4429 update bean id to view setting instead of view behavior * BXC-4429 update relationship object to string * BXC-4429 fix expected param from view behavior object to string * Bxc 4428 solr updates (#1690) * BXC-4428 start solr indexing of view behavior property * BXC-4428 building solr indexing actions and filter * BXC-4428 add indexing action to processor * BXC-4428 account for possible null and add action and pipeline for solr * BXC-4428 update null check and tests accordingly * BXC-4428 add continuous to view settings dropdown * BXC-4428 add content status filter to view behavior pipeline * BXC-4428 exclude view behavior tags from showing up * BXC-4434 finish up csv code and add test * Bxc 4431 view behavior manifests (#1697) * BXC-4431 add viewing direction and behavior to manifest * BXC-4431 use isEmpty instead * BXC-4431 get rid of unused imports * BXC-4431 update logic to test for work * BXC-4431 removing unused method * BXC-4431 adding query and serialization code for view behavior * BXC-4431 remove unused import * BXC-4431 add view behavior solr field for admin list * BXC-4431 remove unused import --------- Co-authored-by: Dean Farrell <[email protected]> Co-authored-by: Sharon Luong <[email protected]> Co-authored-by: Ben Pennell <[email protected]> Co-authored-by: Ben Pennell <[email protected]> Co-authored-by: Anna Goslen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes the temp files created when exporting XML and adds related tests.
https://unclibrary.atlassian.net/browse/BXC-4416