-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BXC-4330 - IIIFv3 manifests #1620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some small changes and questions
...rvices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/IiifV3ManifestService.java
Show resolved
Hide resolved
...rvices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/IiifV3ManifestService.java
Show resolved
Hide resolved
} | ||
|
||
@Test | ||
public void buildManifestNoViewableTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change the test name to buildManifestNoViewableFilesTest
to make it more clear
} | ||
|
||
@Test | ||
public void buildManifestWorkWithoutViewableTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add Files
here too
...vices-app/src/test/java/edu/unc/lib/boxc/web/services/rest/IiifV3ManifestControllerTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much clearer! thank you!
https://unclibrary.atlassian.net/browse/BXC-4330
An example manifest for a work with one image file: