fix: ensure token lists and balances are loaded for new safe or network #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsteenkamp89
changed the title
gsteenkamp89
force-pushed
the
gerhard/uma-2395-osnap-snapshot-tx-builder-bug
branch
from
ab9f1e5 to
9f30463
Compare
daywiss
reviewed
Feb 22, 2024
| const amount = ref(props.transaction.amount ?? ''); | ||
| const recipient = ref(props.transaction.recipient ?? ''); | ||
| const tokens = ref<Token[]>([nativeAsset, ...props.tokens]); | ||
| const tokens = ref<Token[]>(props.tokens); |
There was a problem hiding this comment.
i think we need to keep the native asset as first token in the list. is that possible?
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes UMA-2395 UMA-2388
motivation
There was a bug in the transaction builder where the app would load all tokens you have balances for (your safe on a certain network), then when you switch safes, that list of tokens would not update. We also were not including the balance of the native token in the token chooser modal. This was because the balance pulled from gnosis, if that balance was for a native token it would be stripped out by the app, then later we just hardcoded in the native asset for the chain as an option, but without the balance info.
This PR rectifies some of the state management so that we relaod token balances and token lists when we switch safes.
It also ensures we keep the safe's balance for native tokens so we can display this data to the user.