fix: osnap improve how osnap form validates trarnsactions #123
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| } catch (error) { | ||
| return undefined; | ||
| return parseUnits('0', props.decimals).toString(); |
There was a problem hiding this comment.
do you actually need to call parse units on 0? cant you just put '0'?
There was a problem hiding this comment.
also im not sure if we should really be resetting input box to 0 if theres an error
| emit('updateTransaction', transaction); | ||
| return; | ||
| if (!isTransactionValid) { | ||
| console.warn('invalid transaction'); | ||
| } | ||
| } catch (error) { |
There was a problem hiding this comment.
what happens here? if transaction errors the parent never sees this is invalid
There was a problem hiding this comment.
can remove conditional entirely
| @@ -24,7 +24,7 @@ const emit = defineEmits<{ | |||
|
|
|||
| const to = ref(props.transaction.to ?? ''); | |||
| const isToValid = computed(() => { | |||
| return to.value === '' || isAddress(to.value); | |||
| return to.value !== '' && isAddress(to.value); | |||
There was a problem hiding this comment.
oh i need to revert this change, since value should be allowed to be 0
| emit('updateTransaction', transaction); | ||
| } catch { | ||
| props.setTransactionAsInvalid(); |
There was a problem hiding this comment.
this is essentially what I'm doing in each transaction type.
If validation fails, we throw, then in the catch block we keep the data the same upstream, but we add an invalid flag.
the form doesn't lose it's state. so as soon as the user inputs data that doesn't cause the create<TransactionType> to throw, we can update state upstream with the formatted Tx and set it to be valid
* lowercase useraddress from url * lowercase id here
…orm-validates-trarnsactions
gsteenkamp89
changed the base branch from
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
to
master
gsteenkamp89
changed the base branch from
master
to
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
motivation
disables publish until ALL transactions in the builder are valid