Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove custom inactive osnap button styles #116

Conversation

gsteenkamp89
Copy link

Fixes #UMA-2092

screenshots:
ACTIVE
Screenshot 2023-11-28 at 15 19 39

INACTIVE

Screenshot 2023-11-28 at 15 19 58

inactive dark

Screenshot 2023-11-28 at 15 20 02

@gsteenkamp89 gsteenkamp89 requested a review from daywiss November 28, 2023 13:20
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview Nov 28, 2023 1:20pm
snapshot-goerli ✅ Ready (Inspect) Visit Preview Nov 28, 2023 1:20pm

@gsteenkamp89 gsteenkamp89 merged commit 6c0a1fd into add-osnap-plugin Nov 28, 2023
4 checks passed
@gsteenkamp89 gsteenkamp89 deleted the gerhard/uma-2092-remove-custom-inactive-osnap-button-styles branch November 28, 2023 13:28
daywiss added a commit that referenced this pull request Nov 29, 2023
* add activate osnap button

Signed-off-by: ryanwolhuter <[email protected]>

* bubble emits up

Signed-off-by: ryanwolhuter <[email protected]>

* add is osnap enabled prop

Signed-off-by: ryanwolhuter <[email protected]>

* add safe app link

Signed-off-by: ryanwolhuter <[email protected]>

* add disclaimer

Signed-off-by: ryanwolhuter <[email protected]>

* reduce text size

Signed-off-by: ryanwolhuter <[email protected]>

* update safe app url

Signed-off-by: ryanwolhuter <[email protected]>

* fix tailwind mistake

Signed-off-by: ryanwolhuter <[email protected]>

* use params object

Signed-off-by: ryanwolhuter <[email protected]>

* add is osnap enabled check

Signed-off-by: ryanwolhuter <[email protected]>

* add new osnap plugin

Signed-off-by: ryanwolhuter <[email protected]>

* use presence of plugin to determine if is enabled

Signed-off-by: ryanwolhuter <[email protected]>

* move enable osnap logic out of settings

Signed-off-by: ryanwolhuter <[email protected]>

* switch to composition api

Signed-off-by: ryanwolhuter <[email protected]>

* update types

Signed-off-by: ryanwolhuter <[email protected]>

* remove batch logic from transactions

Signed-off-by: ryanwolhuter <[email protected]>

* remove multisend from contract interaction

Signed-off-by: ryanwolhuter <[email protected]>

* remove multisend from transfer funds

Signed-off-by: ryanwolhuter <[email protected]>

* add correct token type

Signed-off-by: ryanwolhuter <[email protected]>

* refactor transfer nft

Signed-off-by: ryanwolhuter <[email protected]>

* refactor raw transaction input

Signed-off-by: ryanwolhuter <[email protected]>

* add model value and config types

Signed-off-by: ryanwolhuter <[email protected]>

* add model value types

Signed-off-by: ryanwolhuter <[email protected]>

* add transactions by treasury address type

Signed-off-by: ryanwolhuter <[email protected]>

* add high level interface types

Signed-off-by: ryanwolhuter <[email protected]>

* remove batches logic

Signed-off-by: ryanwolhuter <[email protected]>

* wire up module address query

Signed-off-by: ryanwolhuter <[email protected]>

* refactor raw transaction

Signed-off-by: ryanwolhuter <[email protected]>

* refactor contract interaction

Signed-off-by: ryanwolhuter <[email protected]>

* only allow one safe

Signed-off-by: ryanwolhuter <[email protected]>

* refactor proposal component

Signed-off-by: ryanwolhuter <[email protected]>

* rename prop for clarity

Signed-off-by: ryanwolhuter <[email protected]>

* auto select safe on mount

Signed-off-by: ryanwolhuter <[email protected]>

* fix reference error

Signed-off-by: ryanwolhuter <[email protected]>

* fix collectable fetch bug

Signed-off-by: ryanwolhuter <[email protected]>

* fix short name in type

Signed-off-by: ryanwolhuter <[email protected]>

* remove redundant labels

Signed-off-by: ryanwolhuter <[email protected]>

* add types for token fetch logic

Signed-off-by: ryanwolhuter <[email protected]>

* fix typo

Signed-off-by: ryanwolhuter <[email protected]>

* use update for event name

Signed-off-by: ryanwolhuter <[email protected]>

* add update transaction event to raw

Signed-off-by: ryanwolhuter <[email protected]>

* add placeholder data display

Signed-off-by: ryanwolhuter <[email protected]>

* add types for transfer nft

Signed-off-by: ryanwolhuter <[email protected]>

* rename is proposal to is read only

Signed-off-by: ryanwolhuter <[email protected]>

* add contract interaction validation

Signed-off-by: ryanwolhuter <[email protected]>

* clear parameter on method change

Signed-off-by: ryanwolhuter <[email protected]>

* add individual parameter examples

Signed-off-by: ryanwolhuter <[email protected]>

* use disabled inputs for read only

Signed-off-by: ryanwolhuter <[email protected]>

* remove unused files

Signed-off-by: ryanwolhuter <[email protected]>

* remove legacy function code

Signed-off-by: ryanwolhuter <[email protected]>

* organize exports

Signed-off-by: ryanwolhuter <[email protected]>

* rename for clarity

Signed-off-by: ryanwolhuter <[email protected]>

* use method name instead of index

Signed-off-by: ryanwolhuter <[email protected]>

* use existing data if it exists

Signed-off-by: ryanwolhuter <[email protected]>

* use list of one collectable when is read only

Signed-off-by: ryanwolhuter <[email protected]>

* re-add activate osnap button

Signed-off-by: ryanwolhuter <[email protected]>

* only show osnap button when plugin is present

Signed-off-by: ryanwolhuter <[email protected]>

* handle undefined assets

Signed-off-by: ryanwolhuter <[email protected]>

* make transaction fields possibly undefined

Signed-off-by: ryanwolhuter <[email protected]>

* disable dropdown when read only

Signed-off-by: ryanwolhuter <[email protected]>

* add loading safes state

Signed-off-by: ryanwolhuter <[email protected]>

* use modal select for transaction type

Signed-off-by: ryanwolhuter <[email protected]>

* add transaction builder styles

Signed-off-by: ryanwolhuter <[email protected]>

* add style variant for proposal

Signed-off-by: ryanwolhuter <[email protected]>

* re-add osnap modal

Signed-off-by: ryanwolhuter <[email protected]>

* use separate page for read only

Signed-off-by: ryanwolhuter <[email protected]>

* fix import error

Signed-off-by: ryanwolhuter <[email protected]>

* make address required

Signed-off-by: ryanwolhuter <[email protected]>

* use transfer funds as default

Signed-off-by: ryanwolhuter <[email protected]>

* add legacy plugin warning

Signed-off-by: ryanwolhuter <[email protected]>

* update is osnap enabled on window focus

Signed-off-by: ryanwolhuter <[email protected]>

* extract safe link logic

Signed-off-by: ryanwolhuter <[email protected]>

* use modal for safe select

Signed-off-by: ryanwolhuter <[email protected]>

* add comments for types

Signed-off-by: ryanwolhuter <[email protected]>

* remove redundant functions

Signed-off-by: ryanwolhuter <[email protected]>

* rename for clarity

Signed-off-by: ryanwolhuter <[email protected]>

* remove weird thing

Signed-off-by: ryanwolhuter <[email protected]>

* apply formatting

Signed-off-by: ryanwolhuter <[email protected]>

* revert original changes

Signed-off-by: ryanwolhuter <[email protected]>

* undo old changes

Signed-off-by: ryanwolhuter <[email protected]>

* add end newlines to match old

Signed-off-by: ryanwolhuter <[email protected]>

* update import

Signed-off-by: ryanwolhuter <[email protected]>

* undo accidental rename

Signed-off-by: ryanwolhuter <[email protected]>

* handle legacy plugin

Signed-off-by: ryanwolhuter <[email protected]>

* add no safes warning

Signed-off-by: ryanwolhuter <[email protected]>

* undo wrong change

Signed-off-by: ryanwolhuter <[email protected]>

* remove old redundant styles

Signed-off-by: ryanwolhuter <[email protected]>

* add doc comments for functions

Signed-off-by: ryanwolhuter <[email protected]>

* add proposal details types

Signed-off-by: ryanwolhuter <[email protected]>

* add comments

Signed-off-by: ryanwolhuter <[email protected]>

* add address input types

Signed-off-by: ryanwolhuter <[email protected]>

* add amount input types

Signed-off-by: ryanwolhuter <[email protected]>

* rename component for clarity

Signed-off-by: ryanwolhuter <[email protected]>

* add tokens modal types

Signed-off-by: ryanwolhuter <[email protected]>

* add tokens modal item types

Signed-off-by: ryanwolhuter <[email protected]>

* rename for clarity

Signed-off-by: ryanwolhuter <[email protected]>

* extract submit proposal modal to component

Signed-off-by: ryanwolhuter <[email protected]>

* add error notifications

Signed-off-by: ryanwolhuter <[email protected]>

* simplify proposal state

Signed-off-by: ryanwolhuter <[email protected]>

* split steps into components

Signed-off-by: ryanwolhuter <[email protected]>

* remove redundant action button state

Signed-off-by: ryanwolhuter <[email protected]>

* use shared header

Signed-off-by: ryanwolhuter <[email protected]>

* don't format amount on change

Signed-off-by: ryanwolhuter <[email protected]>

* add assertion failed in oo state

Signed-off-by: ryanwolhuter <[email protected]>

* remove balance logic from details query

Signed-off-by: ryanwolhuter <[email protected]>

* separate proposal details chain call

Signed-off-by: ryanwolhuter <[email protected]>

* refactor proposal state fetching

Signed-off-by: ryanwolhuter <[email protected]>

* warn about disputed proposals

Signed-off-by: ryanwolhuter <[email protected]>

* run prettier

Signed-off-by: ryanwolhuter <[email protected]>

* remove unused types

Signed-off-by: ryanwolhuter <[email protected]>

* move get paged events to events

Signed-off-by: ryanwolhuter <[email protected]>

* add doc comments

Signed-off-by: ryanwolhuter <[email protected]>

* rename for clarity

Signed-off-by: ryanwolhuter <[email protected]>

* do not show edit plugin modal when is osnap

Signed-off-by: ryanwolhuter <[email protected]>

* add readme

Signed-off-by: ryanwolhuter <[email protected]>

* apply formatting

Signed-off-by: ryanwolhuter <[email protected]>

* fix wrong function interface

Signed-off-by: ryanwolhuter <[email protected]>

* format

Signed-off-by: ryanwolhuter <[email protected]>

* merge latest from origin

Signed-off-by: david <[email protected]>

* fix network id interpretation, and crash when in space.members

* update changes from master

* fix: spacing changes on outcomes page for osnap plugin (#103)

* feat: improve look and feel of transaction builder in osnap (#104)

* fix: formatting

Signed-off-by: david <[email protected]>

* fix: reset to snapshot's standard 42px height (#105)

* feat: uma 1936 add dark mode osnap buttons (#106)

* fix: cosmetic issues (#107)

* fix: remove extra spacing (#108)

* fix: change osnap activated to use snapshot's primary blue color (#109)

* fix:  font colors in configure osnap modal (#111)

* fix: simplify osnap transactions (#112)

* fix: shorten module address in snapshot proposal transaction (#110)

* fix: change osnap opt in instructions container and checkbox (#113)

* fix: remove View on IPFS link (#114)

* fix: show pending notification on signed tx (#115)

* fix: remove custom inactive osnap button styles (#116)

* fix: remove request transaction execution warning message (#117)

---------

Signed-off-by: ryanwolhuter <[email protected]>
Signed-off-by: david <[email protected]>
Co-authored-by: ryanwolhuter <[email protected]>
Co-authored-by: Gerhard Steenkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants