Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: link to dispute cli tool if no data available #204

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

daywiss
Copy link
Collaborator

@daywiss daywiss commented Dec 19, 2024

motivation

we dont wnat to point to legacy dapp anymore

changes

If both graph and web3 fallbacks fail, point to cli dispute tool

Copy link

linear bot commented Dec 19, 2024

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amoy-optimistic-oracle-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 6:36pm
optimistic-oracle-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 6:36pm
sepolia-optimistic-oracle-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 6:36pm

@pumpedlunch
Copy link

we also want to remove the black "Welcome to the new Oracle Dapp. View the legacy Dapp here." banner. See attached screenshot.
image

@pumpedlunch
Copy link

how can i view what the red banner looks like? I don't know how to view the preview deployments under the conditions of:

  1. Subgraph outage
  2. Subgraph and RPC outage

@daywiss
Copy link
Collaborator Author

daywiss commented Dec 31, 2024

got rid of the banner as well as the link to the cli app

@daywiss
Copy link
Collaborator Author

daywiss commented Dec 31, 2024

how can i view what the red banner looks like? I don't know how to view the preview deployments under the conditions of:

Subgraph outage
Subgraph and RPC outage

difficult to see these without running locally, but let me do more testing with subgraph outage and rpc fallback in new pr

@daywiss daywiss merged commit 7bf0db5 into master Dec 31, 2024
4 checks passed
@daywiss daywiss deleted the david/uma-2808-oracle-dapp-remove-legacy-dapp-link branch December 31, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants