Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging for incoming server requests #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

purusharths
Copy link
Contributor

Same as #14 (closed) without duplicate commits.

The server now prints out incoming requests with some associated metadata
Function call changed to: UMBridge.serve_models([testmodel], 5232, true) with the last Bool argument acting as a trigger to initiate logging (default argument is false).

As of now, there's an extra level of verbosity with all Evaluate calls being printed out -> a possible resolution could be to export the logs to file instead. tail -f <filename> | grep "keywords" can then be used to filter for incoming requests. OR use a separate argument to enalbe logging for evaluate all together?

The two TODO's mentioned in with_logging, and serve_models refer to which of the two approach would be preferred.

@annereinarz
Copy link
Member

My preference would be to avoid writing extra files.

Perhaps allowing for different levels of verbosity rather than bool would resolve this?

@linusseelinger thoughts?

@purusharths
Copy link
Contributor Author

Alright. I wanted to add the logging for python serve as well. Will employ the same approach as here once finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants