Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT Adult and Child Pages #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CT Adult and Child Pages #1

wants to merge 1 commit into from

Conversation

eudson
Copy link

@eudson eudson commented Sep 13, 2023

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

Copy link
Contributor

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some clean up comments that can come later on

<Tab>{t("tabTwo", "Tab Two")}</Tab>
<Tab>{t("tabThree", "Tab Three")}</Tab>
<Tab className="tab-12rem">{t("tabOne", "Visits")}</Tab>
<Tab>{t("tabTwo", "Problems (Wahala)")}</Tab>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional 😅

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL... of course. AI doesn't speak pigin yet

import React, { useMemo } from "react";
import { useTranslation } from "react-i18next";
import {
EmptyStateComingSoon,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is no longer necessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes. Will clean it up

@@ -44,11 +44,14 @@
"url": "https://github.com/UCSF-IGHS/openmrs-esm-rwanda/issues"
},
"dependencies": {
"@carbon/react": "^1.33.1",
"@carbon/react": "1.37.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can be reverted. Not a blocker though cause it's being overriden by the resolution

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that

Comment on lines 41 to +42
"name": "care-and-treatment-ext",
"slot": "care-and-treatment-slot",
"slot": "adult-care-and-treatment-slot",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's match these 2 by adding adult- to the name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Boss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants