-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CT Adult and Child Pages #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some clean up comments that can come later on
<Tab>{t("tabTwo", "Tab Two")}</Tab> | ||
<Tab>{t("tabThree", "Tab Three")}</Tab> | ||
<Tab className="tab-12rem">{t("tabOne", "Visits")}</Tab> | ||
<Tab>{t("tabTwo", "Problems (Wahala)")}</Tab> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intentional 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL... of course. AI doesn't speak pigin yet
import React, { useMemo } from "react"; | ||
import { useTranslation } from "react-i18next"; | ||
import { | ||
EmptyStateComingSoon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import is no longer necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes. Will clean it up
@@ -44,11 +44,14 @@ | |||
"url": "https://github.com/UCSF-IGHS/openmrs-esm-rwanda/issues" | |||
}, | |||
"dependencies": { | |||
"@carbon/react": "^1.33.1", | |||
"@carbon/react": "1.37.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change can be reverted. Not a blocker though cause it's being overriden by the resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger that
"name": "care-and-treatment-ext", | ||
"slot": "care-and-treatment-slot", | ||
"slot": "adult-care-and-treatment-slot", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's match these 2 by adding adult-
to the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK Boss
Requirements
For changes to apps
If applicable
Summary
Screenshots
Related Issue
Other