small rationalising of warnings #1432
Merged
+35
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KrisThielemans
commented
May 16, 2024
KrisThielemans
commented
- remove warnings related to block variables when parsing a cylindrical scanner
- some explanation in warnings
- convert warnings on disabled symmetries to info()
- remove warnings related to block variables when parsing a cylindrical scanner - some explanation in warnings - convert warnings on disabled symmetries to info()
KrisThielemans
commented
May 16, 2024
| @@ -1032,7 +1032,7 @@ InterfilePDFSHeader::post_processing() | |||
| { | |||
| warning("Inconsistent number of TOF bins (" + std::to_string(this->num_timing_poss) | |||
| + ") and size of the 'TOF bin order' list (" + std::to_string(this->timing_poss_sequence.size()) + ")."); | |||
| // return true; | |||
| return true; | |||
There was a problem hiding this comment.
@NicoleJurjew I've made this into a failure. (Seems weird to try and go ahead of the sizes are incorrect.). Let me know ASAP if this is not ok.
There was a problem hiding this comment.
Hey Kris, I agree, that wouldn't make sense. With the new script we're not manually editing the TOF bin order anymore, so this won't trip us up for Vision files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.