Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing all occurrences of abs() to std::abs() #1425

Merged

Conversation

markus-jehl
Copy link
Contributor

Changes in this pull request

Replaced all occurrences of abs() with std::abs()

Testing performed

unit tests

Related issues

fixes #1415

Checklist before requesting a review

  • [] I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • [] The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@KrisThielemans KrisThielemans merged commit 5e4fd8c into UCL:master May 15, 2024
9 checks passed
NikEfth pushed a commit that referenced this pull request May 16, 2024
* Changing all occurences of abs() to std::abs()
---------

Co-authored-by: Markus Jehl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Other places that use abs as opposed to std::abs for floats/doubles that could be affected:
2 participants