Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWIG: expose more LOR and listmode classes #1288

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

KrisThielemans
Copy link
Collaborator

  • Add missing LOR classes
  • Rename FloatLOR to LOR in SWIG
  • Add missing ListRecord etc.

Currently python3 crashes when I import stir, but that might be a local problem.

- add LORAs2Points etc
- added .h file to work-around SWIG bug with private typedef self_type
- removed some old #ifdefs in the .h file

To do this cleanly, move lines from stir.i to separate stir_LOR.i
To do this cleanly, move lines from stir.i to separate stir_listmode.i
…constructors

The first was not implemented, and would need an extra radius argument.
The others called it, but also would have needed a radius
- needed to import ListEvent and ListTime BEFORE ListRecord (SWIG BUG)
- add CListModeData, just in case
- added example and basic test
explicitly use stir/listmode. It doesn't seem to matter, but is cleaner.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and great work with the test and demo

@KrisThielemans KrisThielemans merged commit b5c21c3 into UCL:master Nov 16, 2023
6 checks passed
@KrisThielemans KrisThielemans deleted the SWIGlistmode branch November 16, 2023 18:25
@KrisThielemans KrisThielemans added this to the v6.0 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant