Changed BMP buffer of shorts to chars and increased MCU buffer size #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnider
requested changes
Mar 17, 2022
src/dpu/dpu-jpeg-decode.c
Outdated
| @@ -5,7 +5,7 @@ | |||
| #include "jpeg-host.h" | |||
| #include "dpu-jpeg.h" | |||
|
|
|||
| __mram_noinit short MCU_buffer[NR_TASKLETS][MEGABYTE(16) / NR_TASKLETS]; | |||
| __mram_noinit short MCU_buffer[NR_TASKLETS][MEGABYTE(23) / NR_TASKLETS]; | |||
There was a problem hiding this comment.
Where did you get 23 megabytes from? That is considerably shorter than 16M shorts (=32 MB)
src/bmp.c
Outdated
| @@ -40,7 +40,7 @@ static void initialize_bmp_header(BmpObject *image) { | |||
| image->header.size = image->header.data + image->win_header.length; | |||
| } | |||
|
|
|||
| static void initialize_bmp_body(BmpObject *image, uint32_t image_padding, uint32_t mcu_width, short *MCU_buffer) { | |||
| static void initialize_bmp_body(BmpObject *image, uint32_t image_padding, uint32_t mcu_width, short *MCU_buffer) { //CHANGING BUFF TO SHORT CAUSES ERRORS | |||
There was a problem hiding this comment.
These "errors" are what you are supposed to fix
The data coming from the DPU is an array of shorts. Casting everything to char doesn't change how the data is stored, which is what we are trying to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the buffer array in bmp.c from a short type to a char type. Also increased the MCU buffer size in dpu-jpeg-decode.c to reduce artifacting in outputted .bmp files.