-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPU embedding table implementation with DPU multiColumn strategy #21
Open
dgerinmem
wants to merge
98
commits into
UBC-ECE-Sasha:master
Choose a base branch
from
upmem:multicol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rin/pipeline # Conflicts: # upmem/Makefile # upmem/src/embedding.c # upmem/src/synthetic_dataset_embedding.c
# Conflicts: # upmem/Makefile # upmem/src/dpu/dpu_embedding.c # upmem/src/synthetic_dataset_embedding.c
…ipeline # Conflicts: # upmem/Makefile # upmem/src/embedding.c # upmem/src/synthetic_dataset_embedding.c
…ults(callback)) (#1) * preparation for async * imports cleanup * unused parameter * fixed time counter * added perf counters + experiment * BUG & PERF fix : separate alloc_dpu_results * preparation for async * refacto : dont use precompiler constants * 32 bits int in kernel * formatting * now supports >512 batches * refacto : separates indices, offsets and input info allocation * param : switch to original * fixed * put counters in ifdef blocks * updated clangd * imports cleanup * unused parameter * fixed time counter * added perf counters + experiment * 32 bits int in kernel * formatting * now supports >512 batches * put counters in ifdef blocks * updated clangd * measuring verification time * pipeline stage 1 [build_synthetic_input_data -> synthetic_inference] * few merge fix * bug fix Co-authored-by: SylvanBrocard <[email protected]>
bugfix time measurement use 10 re-run for DPU
# Conflicts: # upmem/Makefile # upmem/include/emb_types.h # upmem/include/embedding.h # upmem/src/embedding.c # upmem/src/synthetic_dataset_embedding.c
feature : RAND_INPUT_SIZE=1 -> synthetic input indices generation with fixed batch size, random Pooling Factor (num indices per lookup) add PERF.md for perf log
separate testbench and embedding lib clean names update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.