Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Sprotty webview #15

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Added Sprotty webview #15

merged 2 commits into from
Mar 11, 2020

Conversation

spoenemann
Copy link
Member

I added a webview that uses sprotty-vscode to integrate yang-sprotty diagrams.

Further changes:

  • Switched to Yarn
  • Aligned project configuration with more recent projects of ours
  • Aligned project structure to the state-extension example

@spoenemann spoenemann requested a review from JanKoehnlein March 10, 2020 10:06
@spoenemann
Copy link
Member Author

Open issues: #13, #14

JanKoehnlein
JanKoehnlein approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoenemann spoenemann merged commit f1fed25 into master Mar 11, 2020
@spoenemann spoenemann deleted the sprotty_view branch March 11, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoenemann @JanKoehnlein