Attempt to fix crashing on launch

TypeDuck-HK · Jan 31, 2024 · 3f3b4c2 · 3f3b4c2
1 parent f59a111
commit 3f3b4c2
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 9 deletions.
diff --git a/TypeDuck/EventHandler.swift b/TypeDuck/EventHandler.swift
@@ -14,7 +14,7 @@ extension TypeDuckInputController {
                 let modifiers = event.modifierFlags
                 let shouldIgnoreCurrentEvent: Bool = modifiers.contains(.command) || modifiers.contains(.option)
                 guard !shouldIgnoreCurrentEvent else { return false }
-                let client: IMKTextInput? = (sender as? IMKTextInput) ?? currentClient
+                let client: InputClient? = (sender as? InputClient) ?? currentClient
                 currentOrigin = client?.position
                 let currentClientID = currentClient?.uniqueClientIdentifierString()
                 let clientID = client?.uniqueClientIdentifierString()

diff --git a/TypeDuck/Info.plist b/TypeDuck/Info.plist
@@ -43,7 +43,7 @@
 	<key>ITSAppUsesNonExemptEncryption</key>
 	<false/>
 	<key>InputMethodConnectionName</key>
-	<string>hk_eduhk_inputmethod_TypeDuck_Connection</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)_Connection</string>
 	<key>InputMethodServerControllerClass</key>
 	<string>$(PRODUCT_MODULE_NAME).TypeDuckInputController</string>
 	<key>InputMethodServerDelegateClass</key>

diff --git a/TypeDuck/TypeDuck.entitlements b/TypeDuck/TypeDuck.entitlements
@@ -4,5 +4,7 @@
 <dict>
 	<key>com.apple.security.app-sandbox</key>
 	<true/>
+	<key>com.apple.security.temporary-exception.mach-register.global-name</key>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)_Connection</string>
 </dict>
 </plist>
diff --git a/TypeDuck/TypeDuckApp.swift b/TypeDuck/TypeDuckApp.swift
@@ -1,6 +1,7 @@
 import AppKit
 import InputMethodKit
 
+@objc(PrincipalApplication)
 final class PrincipalApplication: NSApplication {
 
         private let appDelegate = AppDelegate()
@@ -16,15 +17,16 @@ final class PrincipalApplication: NSApplication {
 }
 
 @main
+@objc(AppDelegate)
 final class AppDelegate: NSObject, NSApplicationDelegate {
 
-        static var server: IMKServer? = nil
+        var server: IMKServer? = nil
 
         func applicationDidFinishLaunching(_ notification: Notification) {
                 handleCommandLineArguments()
-                let name: String = (Bundle.main.infoDictionary?["InputMethodConnectionName"] as? String) ?? "hk_eduhk_inputmethod_TypeDuck_Connection"
+                let name: String = (Bundle.main.infoDictionary?["InputMethodConnectionName"] as? String) ?? "hk.eduhk.inputmethod.TypeDuck_Connection"
                 let identifier: String = Bundle.main.bundleIdentifier ?? "hk.eduhk.inputmethod.TypeDuck"
-                Self.server = IMKServer(name: name, bundleIdentifier: identifier)
+                server = IMKServer(name: name, bundleIdentifier: identifier)
         }
 
         private func handleCommandLineArguments() {

diff --git a/TypeDuck/TypeDuckInputController.swift b/TypeDuck/TypeDuckInputController.swift
@@ -97,7 +97,9 @@ final class TypeDuckInputController: IMKInputController {
 
         private lazy var screenWidth: CGFloat = NSScreen.main?.frame.size.width ?? 1920
         lazy var currentOrigin: CGPoint? = nil
-        lazy var currentClient: IMKTextInput? = nil {
+
+        typealias InputClient = (IMKTextInput & NSObjectProtocol)
+        lazy var currentClient: InputClient? = nil {
                 didSet {
                         guard let origin = currentClient?.position else { return }
                         let isRegularHorizontal: Bool = origin.x < (screenWidth - 400)
@@ -128,8 +130,7 @@ final class TypeDuckInputController: IMKInputController {
         }
         override init!(server: IMKServer!, delegate: Any!, client inputClient: Any!) {
                 super.init(server: server, delegate: delegate, client: inputClient)
-                let parameterInputClient = inputClient as? (IMKTextInput & NSObjectProtocol)
-                let currentInputClient = parameterInputClient ?? client()
+                let currentInputClient = (inputClient as? InputClient) ?? client()
                 activateServer(currentInputClient)
         }
         override func activateServer(_ sender: Any!) {
@@ -140,7 +141,7 @@ final class TypeDuckInputController: IMKInputController {
                 if inputStage.isBuffering {
                         clearBufferText()
                 }
-                currentClient = sender as? IMKTextInput
+                currentClient = sender as? InputClient
                 currentOrigin = currentClient?.position
                 prepareMasterWindow()
                 if appContext.inputForm.isOptions {