[TT-13769] Extend plugin compiler test with arm64 cross build #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API Changes no api changes detected |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
andrei-tyk
approved these changes
Dec 27, 2024
andrei-tyk
reviewed
Dec 27, 2024
|
|
/release to release-5.3 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Dec 28, 2024
### **PR Type**
tests
___
### **Description**
- Extended the plugin compiler test script to include a
cross-compilation step for the `arm64` architecture.
- Added a Docker command with the `GOARCH=arm64` environment variable to
enable arm64 builds.
- Ensures compatibility and testing for arm64 architecture in the plugin
compiler.
___
### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>test.sh</strong><dd><code>Add arm64 cross-compilation
to plugin compiler test script</code></dd></summary>
<hr>
ci/tests/plugin-compiler/test.sh
<li>Added a cross-compilation step for building the plugin for the
<code>arm64</code> <br>architecture.<br> <li> Introduced the use of the
<code>GOARCH=arm64</code> environment variable in the <br>Docker
command.<br>
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6813/files#diff-2a616e71f9e61519f1e7fcd658f73d83a8ae561ef3108da000e7f5d77e38c244">+3/-0</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
___
> 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull
request to receive relevant information
---------
Co-authored-by: Tit Petric <[email protected]>
(cherry picked from commit f2ff583)
|
@titpetric Succesfully merged PR |
buger
added a commit
that referenced
this pull request
Dec 28, 2024
…rm64 cross build (#6813) [TT-13769] Extend plugin compiler test with arm64 cross build (#6813) ### **PR Type** tests ___ ### **Description** - Extended the plugin compiler test script to include a cross-compilation step for the `arm64` architecture. - Added a Docker command with the `GOARCH=arm64` environment variable to enable arm64 builds. - Ensures compatibility and testing for arm64 architecture in the plugin compiler. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>test.sh</strong><dd><code>Add arm64 cross-compilation to plugin compiler test script</code></dd></summary> <hr> ci/tests/plugin-compiler/test.sh <li>Added a cross-compilation step for building the plugin for the <code>arm64</code> <br>architecture.<br> <li> Introduced the use of the <code>GOARCH=arm64</code> environment variable in the <br>Docker command.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6813/files#diff-2a616e71f9e61519f1e7fcd658f73d83a8ae561ef3108da000e7f5d77e38c244">+3/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information --------- Co-authored-by: Tit Petric <[email protected]>
tykbot bot
pushed a commit
that referenced
this pull request
Dec 28, 2024
…rm64 cross build (#6813) [TT-13769] Extend plugin compiler test with arm64 cross build (#6813) ### **PR Type** tests ___ ### **Description** - Extended the plugin compiler test script to include a cross-compilation step for the `arm64` architecture. - Added a Docker command with the `GOARCH=arm64` environment variable to enable arm64 builds. - Ensures compatibility and testing for arm64 architecture in the plugin compiler. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>test.sh</strong><dd><code>Add arm64 cross-compilation to plugin compiler test script</code></dd></summary> <hr> ci/tests/plugin-compiler/test.sh <li>Added a cross-compilation step for building the plugin for the <code>arm64</code> <br>architecture.<br> <li> Introduced the use of the <code>GOARCH=arm64</code> environment variable in the <br>Docker command.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6813/files#diff-2a616e71f9e61519f1e7fcd658f73d83a8ae561ef3108da000e7f5d77e38c244">+3/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information --------- Co-authored-by: Tit Petric <[email protected]> (cherry picked from commit 0486232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
tests
Description
arm64architecture.GOARCH=arm64environment variable to enable arm64 builds.Changes walkthrough 📝
test.sh
Add arm64 cross-compilation to plugin compiler test scriptci/tests/plugin-compiler/test.sh
arm64architecture.
GOARCH=arm64environment variable in theDocker command.