[SYSE-370 release-5.4] June template application

[alephnull]

User description

• Images not being pushed to dockerhub on tag when distroless feature is missing
• Policy match fix
• Fix github ref name for test-controller ui on push trigger
• Test controller UI missing conf for push event and other missconfigs
• Test controller UI duplicated lines under pump & sink
• Quality gates for tyk-analitycs UI and API regression tests
• release-5.3 is not treated correctly in test-controller logic
• Implement custom rules for enterprise artifacts in package promotion
• Test controller UI
• Accomodate templates for new controller UI
• Add mongo7 and redis7 with cache_DB config field

---

PR Type

Enhancement, Bug fix

---

Description

• Updated docker/build-push-action from v5 to v6 to ensure compatibility and leverage new features.
• Fixed the GitHub ref name for the test-controller UI on push trigger to ensure correct references.
• Removed redundant environment variables to streamline the workflow.
• Consolidated test execution and metadata generation steps to improve efficiency and readability.

---

Changes walkthrough 📝

	Relevant files
Enhancement	release.yml Update Docker build action and fix test-controller UI configurations .github/workflows/release.yml Updated docker/build-push-action from v5 to v6. Fixed GitHub ref name for test-controller UI on push trigger. Removed redundant environment variables. Consolidated test execution and metadata generation steps. +13/-36

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

API Changes

no api changes detected

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Version Upgrade The PR upgrades docker/build-push-action from v5 to v6. Ensure that all features used in v5 are compatible with v6 and that no deprecated features are being used. Version Upgrade The PR upgrades docker/build-push-action from v5 to v6. Ensure that all features used in v5 are compatible with v6 and that no deprecated features are being used. Version Upgrade The PR upgrades docker/build-push-action from v5 to v6. Ensure that all features used in v5 are compatible with v6 and that no deprecated features are being used. Version Upgrade The PR upgrades docker/build-push-action from v5 to v6. Ensure that all features used in v5 are compatible with v6 and that no deprecated features are being used.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Add error handling to the docker compose command to enhance robustness Ensure that the docker compose command includes error handling to manage potential failures during the setup of environments. .github/workflows/release.yml [299] -docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d +docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d || echo "Error during docker compose up" Suggestion importance[1-10]: 10 Why: Adding error handling to the docker compose command is crucial for managing potential failures during the setup of environments, thereby improving the robustness of the CI/CD pipeline.	10
Maintainability	Simplify the conditional assignment of BASE_REF for clarity Replace the complex conditional expression for BASE_REF with a simpler or more explicit approach to improve readability and maintainability. .github/workflows/release.yml [280] -BASE_REF: ${{startsWith(github.event_name, 'pull_request') && github.base_ref || github.ref_name}} +BASE_REF: ${{ github.event_name == 'pull_request' ? github.base_ref : github.ref_name }} Suggestion importance[1-10]: 9 Why: Simplifying the conditional expression improves readability and maintainability, making the code easier to understand and less error-prone.	9
Enhancement	Update the Docker build-push-action to the latest version for enhanced security and features Update the docker/build-push-action to the latest version (v7) to ensure compatibility with new features and security patches. .github/workflows/release.yml [141] -uses: docker/build-push-action@v6 +uses: docker/build-push-action@v7 Suggestion importance[1-10]: 8 Why: Updating to the latest version of the Docker build-push-action ensures compatibility with new features and security patches, which is important for maintaining the CI/CD pipeline's reliability and security.	8
Best practice	Use a more specific runner version to ensure consistent CI behavior Consider using a more specific tag than ubuntu-latest-m-2 for the runs-on attribute to avoid potential issues with unexpected updates. .github/workflows/release.yml [229] -runs-on: ubuntu-latest-m-2 +runs-on: ubuntu-20.04-m-2 Suggestion importance[1-10]: 7 Why: Using a specific runner version helps avoid potential issues with unexpected updates, ensuring consistent behavior in the CI environment.	7

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

[ermirizio]

closing in favor of release5.5