Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSE-370 release-5.3] June template application #6419

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

alephnull
Copy link
Contributor

@alephnull alephnull commented Jul 17, 2024

  • Fix github ref name for test-controller ui on push trigger
  • Test controller UI missing conf for push event and other missconfigs
  • Test controller UI duplicated lines under pump & sink
  • release-5.3 is not treated correctly in test-controller logic
  • Test controller UI
  • Accomodate templates for new controller UI
  • Add mongo7 and redis7 with cache_DB config field

@alephnull alephnull requested a review from a team as a code owner July 17, 2024 08:12
@alephnull alephnull enabled auto-merge (squash) July 17, 2024 08:12
Copy link
Contributor

API Changes

no api changes detected

Copy link
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Version Upgrade
The PR upgrades docker/build-push-action from v5 to v6. Ensure that all features used in the workflow are compatible with the new version and that no deprecated features are being used.

Environment Variables
Environment variables METADATA_REPORT_PATH and XUNIT_REPORT_PATH were removed from the global environment and added only in specific steps. Verify that these changes do not affect other parts of the workflow where these variables might be needed.

Docker Compose Command
The PR changes Docker Compose commands to include additional flags and configurations. Ensure that these changes are correctly formatted and do not introduce any syntax errors or runtime issues.

Copy link
Contributor

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Best practice
Implement error handling for Docker compose commands to enhance robustness

Add error handling for the Docker compose commands to manage failures gracefully.

.github/workflows/release.yml [299]

-docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d
+docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d || echo "Error during Docker compose up"
 
Suggestion importance[1-10]: 9

Why: Adding error handling for Docker compose commands improves the robustness of the workflow by managing failures gracefully. This is a significant improvement for reliability.

9
Use a specific Ubuntu version to ensure consistent environment behavior

Consider using a more specific tag than ubuntu-latest for the runs-on attribute to
avoid unexpected changes when new versions are released.

.github/workflows/release.yml [229]

-runs-on: ubuntu-latest-m-2
+runs-on: ubuntu-20.04-m-2
 
Suggestion importance[1-10]: 7

Why: Using a specific Ubuntu version helps avoid unexpected changes when new versions are released, ensuring a consistent environment. This is a best practice for stability.

7
Enhancement
Update the Docker build-push action to the latest version for enhanced features and security

Update the docker/build-push-action to the latest version (v7) to ensure
compatibility with the latest features and security patches.

.github/workflows/release.yml [141]

-uses: docker/build-push-action@v6
+uses: docker/build-push-action@v7
 
Suggestion importance[1-10]: 8

Why: Updating to the latest version of the Docker build-push action ensures compatibility with the latest features and security patches. This is a good enhancement for maintaining up-to-date dependencies.

8

@buger buger force-pushed the releng/release-5.3 branch 18 times, most recently from fd7a82e to f6a6fc7 Compare July 22, 2024 12:09
@alephnull alephnull force-pushed the releng/release-5.3 branch from f6a6fc7 to 89ddcdb Compare July 22, 2024 14:58
@buger buger force-pushed the releng/release-5.3 branch 3 times, most recently from d82f8bc to 3b80810 Compare July 22, 2024 19:04
@buger buger force-pushed the releng/release-5.3 branch 3 times, most recently from 5bf8143 to 5aede00 Compare August 6, 2024 19:27
@buger buger force-pushed the releng/release-5.3 branch 8 times, most recently from 1d5b8f4 to ec14f03 Compare August 9, 2024 22:39
@buger buger force-pushed the releng/release-5.3 branch 11 times, most recently from 01e084b to 70cb42a Compare August 19, 2024 19:36
@buger buger force-pushed the releng/release-5.3 branch from 70cb42a to e4d8a2f Compare August 19, 2024 21:54
Copy link

@alephnull alephnull merged commit e07a493 into release-5.3 Aug 19, 2024
24 of 26 checks passed
@alephnull alephnull deleted the releng/release-5.3 branch August 19, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants