Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-4862] Fix oas headers #5910

Merged
merged 2 commits into from
Dec 22, 2023
Merged

[TT-4862] Fix oas headers #5910

merged 2 commits into from
Dec 22, 2023

Conversation

furkansenharputlu
Copy link
Contributor

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@furkansenharputlu furkansenharputlu self-assigned this Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023 •
edited
Loading

API Changes

no api changes detected

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 22, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@github-actions GitHub Actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Fixing headers in OAS (OpenAPI Specification)
  • 📝 PR summary: This PR is focused on fixing headers in the OpenAPI Specification (OAS). The changes are made in the 'operation.go' file where two lines of code have been added to set 'TransformHeader' and 'TransformResponseHeader' to nil.
  • 📌 Type of PR: Bug fix
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1, because the PR is small and straightforward, involving only two lines of code changes.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is concise and focused on a specific issue, which is good. However, it would be beneficial to include tests that verify the changes made. Also, the PR description could be more detailed, explaining the problem and how the changes solve it.

  • 🤖 Code feedback:
    relevant fileapidef/oas/operation.go
    suggestion      Consider adding a comment explaining why 'TransformHeader' and 'TransformResponseHeader' are being set to nil. This will help other developers understand the reasoning behind this change. [medium]
    relevant lineep.TransformHeader = nil

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@furkansenharputlu furkansenharputlu changed the title Fix oas headers [TT-4862] Fix oas headers Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@furkansenharputlu furkansenharputlu enabled auto-merge (squash) December 22, 2023 16:01
@github-actions GitHub Actions
Copy link
Contributor

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@github-actions GitHub Actions
Copy link
Contributor

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@buger
Copy link
Member

buger commented Dec 22, 2023

API tests result: success ✅
Branch used: refs/pull/5910/merge
Commit:
Triggered by: pull_request (@furkansenharputlu)
Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023 •
edited by jira bot
Loading

API tests result - postgres15-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 9524f89 TT-4862 Fix oas headers (#5910)

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why
    Triggered by: push (@furkansenharputlu)
    Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023 •
edited by jira bot
Loading

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 9524f89 TT-4862 Fix oas headers (#5910)

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why
    Triggered by: push (@furkansenharputlu)
    Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023 •
edited by jira bot
Loading

API tests result - mongo44-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 9524f89 TT-4862 Fix oas headers (#5910)

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why
    Triggered by: push (@furkansenharputlu)
    Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023 •
edited by jira bot
Loading

API tests result - postgres15-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 9524f89 TT-4862 Fix oas headers (#5910)

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why
    Triggered by: push (@furkansenharputlu)
    Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023

API tests result: success ✅
Branch used: refs/pull/5910/merge
Commit: ac99879
Triggered by: pull_request (@furkansenharputlu)
Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023

API tests result: success ✅
Branch used: refs/pull/5910/merge
Commit: 9deaf4e
Triggered by: pull_request (@furkansenharputlu)
Execution page

@buger
Copy link
Member

buger commented Dec 22, 2023

API tests result: success ✅
Branch used: refs/pull/5910/merge
Commit: ce6bfb8
Triggered by: pull_request (@furkansenharputlu)
Execution page

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@buger
Copy link
Member

buger commented Dec 22, 2023

API tests result: success ✅
Branch used: refs/pull/5910/merge
Commit: fbb6c14
Triggered by: pull_request (@furkansenharputlu)
Execution page

@furkansenharputlu furkansenharputlu merged commit 9524f89 into master Dec 22, 2023
21 checks passed
@furkansenharputlu furkansenharputlu deleted the fix/oas-headers branch December 22, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwojciechowski maciejwojciechowski maciejwojciechowski approved these changes

Assignees

@furkansenharputlu furkansenharputlu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furkansenharputlu @buger @maciejwojciechowski