Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changes to support lts branches #5848

Closed
wants to merge 10 commits into from
Closed

add changes to support lts branches #5848

wants to merge 10 commits into from

Conversation

ermirizio
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

API Changes

no api changes detected

@ermirizio ermirizio assigned ermirizio and alephnull and unassigned alephnull Dec 6, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@ermirizio ermirizio requested a review from alephnull December 6, 2023 18:05
@ermirizio ermirizio force-pushed the SYSE-297/fix-default-tag-against-release-branches branch from 3dcd998 to ab49e47 Compare December 26, 2023 05:31
@ermirizio ermirizio removed the request for review from alephnull December 26, 2023 05:41
@ermirizio ermirizio marked this pull request as ready for review December 26, 2023 05:41
@ermirizio ermirizio requested a review from a team as a code owner December 26, 2023 05:41
@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit:
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023 •
edited
Loading

API tests result - postgres15-sha256 env: success ✅
Branch used: refs/pull/5848/merge
Commit: ef1afd7
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023 •
edited
Loading

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/pull/5848/merge
Commit: ef1afd7
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023 •
edited
Loading

API tests result - mongo44-sha256 env: success ✅
Branch used: refs/pull/5848/merge
Commit: ef1afd7
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023 •
edited
Loading

API tests result - postgres15-murmur64 env: success ✅
Branch used: refs/pull/5848/merge
Commit: ef1afd7
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: 88e34fd
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: 0288b4d
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: 77fa61f
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: d71153f
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: 9338bd9
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: edb4b9f
Triggered by: pull_request (@ermirizio)
Execution page

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: 2744451
Triggered by: pull_request (@ermirizio)
Execution page

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@buger
Copy link
Member

buger commented Dec 26, 2023

API tests result: success ✅
Branch used: refs/pull/5848/merge
Commit: ef1afd7
Triggered by: pull_request (@ermirizio)
Execution page

@alephnull
Copy link
Contributor

@ermirizio This one can be closed? I've removed the reviewers so that this doesn't show up in my notifications.

@alephnull alephnull removed the request for review from a team December 27, 2023 05:36
@ermirizio
Copy link
Collaborator Author

closed due to TykTechnologies/gromit#242

@ermirizio ermirizio closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ermirizio ermirizio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ermirizio @buger @alephnull