[TT-10358] Add fallback to default version OAS support #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
furkansenharputlu
force-pushed
the
feature/fallback-to-default-version
branch
from
e42f41a to
a2a3f4e
Compare
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
from
73b8f92 to
d526ee4
Compare
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
from
d526ee4 to
e6154a7
Compare
furkansenharputlu
changed the title
Base automatically changed from
feature/fallback-to-default-version
to
master
October 26, 2023 11:32
|
API Changes --- prev.txt 2023-10-30 07:17:56.981527920 +0000
+++ current.txt 2023-10-30 07:17:52.165385089 +0000
@@ -3857,6 +3857,10 @@
Versions []VersionToID `bson:"versions" json:"versions"` // required
// StripVersioningData is a boolean flag, if set to `true`, the API responses will be stripped of versioning data.
StripVersioningData bool `bson:"stripVersioningData,omitempty" json:"stripVersioningData,omitempty"`
+ // FallbackToDefault controls the behaviour of Tyk when a versioned API is called with a nonexistent version name.
+ // If set to `true` then the default API version will be invoked; if set to `false` Tyk will return an HTTP 404
+ // `This API version does not seem to exist` error in this scenario.
+ FallbackToDefault bool `bson:"fallbackToDefault,omitempty" json:"fallbackToDefault,omitempty"`
}
Versioning holds configuration for API versioning.
|
|
API tests result: success ✅ |
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
from
1f1f3e3 to
17707a8
Compare
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
from
17707a8 to
39efb84
Compare
titpetric
reviewed
Oct 26, 2023
andyo-tyk
requested changes
Oct 26, 2023
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
2 times, most recently
from
99a531b to
f138f07
Compare
furkansenharputlu
requested review from
andyo-tyk
and removed request for
andyo-tyk
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
from
f138f07 to
576fa89
Compare
furkansenharputlu
force-pushed
the
feature/oas-fallback-to-default
branch
from
576fa89 to
3430ca4
Compare
jeffy-mathew
approved these changes
Oct 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
API tests result: success ✅ |
|
API tests result: success ✅ |
|
API tests result: success ✅ |
|
API tests result: success ✅ |
|
/release to release-5.2 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
parent ticket: https://tyktech.atlassian.net/browse/TT-9901 subticket: https://tyktech.atlassian.net/browse/TT-10358 (cherry picked from commit 7c09214)
|
@furkansenharputlu Succesfully merged PR |
buger
added a commit
that referenced
this pull request
Oct 30, 2023
…S support (#5679) [TT-10358] Add fallback to default version OAS support (#5679) parent ticket: https://tyktech.atlassian.net/browse/TT-9901 subticket: https://tyktech.atlassian.net/browse/TT-10358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent ticket: https://tyktech.atlassian.net/browse/TT-9901
subticket: https://tyktech.atlassian.net/browse/TT-10358