Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging to release-4-lts: [10308] Hide expected signature from logs in HMAC (#5648) #5658

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Merging to release-4-lts: [10308] Hide expected signature from logs in HMAC (#5648) #5658

merged 1 commit into from
Oct 20, 2023

Conversation

buger
Copy link
Member

@buger buger commented Oct 20, 2023

[10308] Hide expected signature from logs in HMAC (#5648)

This PR removes the expected HMAC signature from the logs which are
printed when there is a mismatch.

@furkansenharputlu
[10308] Hide expected signature from logs in HMAC (#5648)
3f98664 
This PR removes the expected HMAC signature from the logs which are
printed when there is a mismatch.

(cherry picked from commit cad936a)
@buger buger enabled auto-merge (squash) October 20, 2023 18:47
@sweep-ai
Copy link

sweep-ai bot commented Oct 20, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@buger buger merged commit c6ff6cc into release-4-lts Oct 20, 2023
5 checks passed
@buger buger deleted the merge/release-4-lts/cad936a6325f41468863dd28a31425654d4888d5 branch October 20, 2023 18:49
@ilijabojanovic
Copy link
Member

/release to release-4.0.15

@tykbot
Copy link

tykbot bot commented Oct 20, 2023

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Oct 20, 2023

@ilijabojanovic Succesfully merged PR

@buger
Copy link
Member Author

buger commented Oct 20, 2023

API tests result: success ✅
Branch used: refs/pull/5658/merge
Commit:
Triggered by: pull_request (@buger)
Execution page

@buger
Copy link
Member Author

buger commented Oct 20, 2023

API tests result: success ✅
Branch used: refs/heads/release-4-lts
Commit: c6ff6cc Merging to release-4-lts: [10308] Hide expected signature from logs in HMAC (#5648)

[10308] Hide expected signature from logs in HMAC (#5648)

This PR removes the expected HMAC signature from the logs which are
printed when there is a mismatch.
Triggered by: push (@buger)
Execution page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buger @ilijabojanovic @furkansenharputlu