TT-12780 prevent sql pump to panic when sharding enabled and skip api id is set #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hard-and-skip-api
jeffy-mathew
approved these changes
Nov 27, 2024
sredxny
deleted the
TT-12780-bugfix/dont-crash-sql-pump-with-shard-and-skip-api
branch
|
/release to release-1.11 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
… id is set (#860) * prevent sql pump to panic when sharding enabled and skip api id is set * revert doc change --------- Co-authored-by: sredny buitrago <[email protected]> (cherry picked from commit fbcb614)
|
@sredxny Seems like there is conflict and it require manual merge. |
sredxny
added a commit
that referenced
this pull request
Dec 4, 2024
… id is set (#860) (#862) * prevent sql pump to panic when sharding enabled and skip api id is set * revert doc change --------- Co-authored-by: sredny buitrago <[email protected]> (cherry picked from commit fbcb614) Co-authored-by: Sredny M. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using SQL pump, sharding enabled and skip api id is set then the array of data in the writeData function is empty, then prevent panic when looping over the array
Related Issue
TT-12780
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet