Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Pump not purging records #786

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Bugfix: Pump not purging records #786

merged 1 commit into from
Jan 31, 2024

Conversation

mativm02
Copy link
Contributor

Description

Fixing a bug where Pump wasn't purging records because of a wrong KeyPrefix.

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@mativm02 mativm02 enabled auto-merge (squash) January 31, 2024 14:20
@buger
Copy link
Member

buger commented Jan 31, 2024 •
edited
Loading

API tests result - postgres15-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 224baa3 Removing pointer from AnalyticsStorageConfig variable (#786)
Triggered by: push (@mativm02)
Execution page

@buger
Copy link
Member

buger commented Jan 31, 2024 •
edited
Loading

API tests result - mongo44-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 224baa3 Removing pointer from AnalyticsStorageConfig variable (#786)
Triggered by: push (@mativm02)
Execution page

@mativm02 mativm02 merged commit 224baa3 into master Jan 31, 2024
22 checks passed
@mativm02 mativm02 deleted the fix/not-purging-records branch January 31, 2024 14:37
@mativm02
Copy link
Contributor Author

/release to release-1.9

@tykbot tykbot
Copy link

tykbot bot commented Jan 31, 2024

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Jan 31, 2024
@mativm02
Removing pointer from AnalyticsStorageConfig variable (#786)
86b765d 
(cherry picked from commit 224baa3)
@buger buger mentioned this pull request Jan 31, 2024
Merged
@tykbot tykbot
Copy link

tykbot bot commented Jan 31, 2024

@mativm02 Succesfully merged PR

@buger
Copy link
Member

buger commented Jan 31, 2024

API tests result - postgres15-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 224baa3 Removing pointer from AnalyticsStorageConfig variable (#786)
Triggered by: push (@mativm02)
Execution page

@buger
Copy link
Member

buger commented Jan 31, 2024

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 224baa3 Removing pointer from AnalyticsStorageConfig variable (#786)
Triggered by: push (@mativm02)
Execution page

buger added a commit that referenced this pull request Jan 31, 2024
@buger
Merging to release-1.9: Removing pointer from AnalyticsStorageConfig …
d009eff 
…variable (#786)

Removing pointer from AnalyticsStorageConfig variable (#786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbuchaillot tbuchaillot tbuchaillot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mativm02 @buger @tbuchaillot