Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-1.9: [TT-10673] Upgrading to Go 1.21 (#766) #772

Merged

Conversation

buger
Copy link
Member

@buger buger commented Jan 17, 2024

TT-10673 Upgrading to Go 1.21 (#766)

  • upgrading to Go 1.21

  • fixing loop issue

  • removing comment

  • linting

  • add release 1.19 revert 1.18 req tests

  • removing commented linters

  • removing 1.19 branch from terraform


Co-authored-by: Esteban Ricardo Mirizio [email protected]

* upgrading to Go 1.21

* fixing loop issue

* removing comment

* linting

* add release 1.19 revert 1.18 req tests

* removing commented linters

* removing 1.19 branch from terraform

---------

Co-authored-by: Esteban Ricardo Mirizio <[email protected]>

(cherry picked from commit e2a7a3c)
@buger buger requested a review from a team as a code owner January 17, 2024 13:07
@buger buger enabled auto-merge (squash) January 17, 2024 13:07
Copy link
Contributor

Terraform Format and Style 🖌``

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan

terraform
Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/Tyk/repo-policy-tyk-pump/runs/run-r6FqoSMwxFBJTZmn

Waiting for the plan to start...

Terraform v1.4.6
on linux_amd64
Initializing plugins and modules...
module.tyk-pump.github_repository.repository: Refreshing state... [id=tyk-pump]
module.tyk-pump.github_branch.default: Refreshing state... [id=tyk-pump:master]
module.tyk-pump.github_branch.release_branches["master"]: Refreshing state... [id=tyk-pump:master]
module.tyk-pump.github_branch_protection.automerge["release-1.8"]: Refreshing state... [id=BPR_kwDOAwBg2c4CS279]
module.tyk-pump.github_branch.release_branches["release-1.7"]: Refreshing state... [id=tyk-pump:release-1.7]
module.tyk-pump.github_branch.release_branches["release-1.8"]: Refreshing state... [id=tyk-pump:release-1.8]
module.tyk-pump.github_branch_protection.automerge["release-1.7"]: Refreshing state... [id=BPR_kwDOAwBg2c4B_GSq]
module.tyk-pump.github_branch_protection.automerge["master"]: Refreshing state... [id=MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMTkxOTM5MzE=]
module.tyk-pump.github_branch_default.default: Refreshing state... [id=tyk-pump]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.tyk-pump.github_branch_protection.automerge["master"] will be updated in-place
  ~ resource "github_branch_protection" "automerge" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMTkxOTM5MzE="
        # (11 unchanged attributes hidden)

      ~ required_pull_request_reviews {
          ~ required_approving_review_count = 0 -> 1
            # (6 unchanged attributes hidden)
        }

      ~ required_status_checks {
          ~ contexts = [
              + "1.21-bullseye",
              + "Go 1.21 tests",
              + "api-tests (murmur64, mongo44)",
              + "api-tests (murmur64, postgres15)",
              + "api-tests (sha256, mongo44)",
              + "api-tests (sha256, postgres15)",
            ]
            # (1 unchanged attribute hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.


Pushed by: @buger, Action: pull_request

@buger
Copy link
Member Author

buger commented Jan 17, 2024

API tests result - mongo44-murmur64 env: skipped 🚫
Branch used: refs/heads/release-1.9
Commit: 389f8d3 Merging to release-1.9: TT-10673 Upgrading to Go 1.21 (#766)

TT-10673 Upgrading to Go 1.21 (#766)

  • upgrading to Go 1.21

  • fixing loop issue

  • removing comment

  • linting

  • add release 1.19 revert 1.18 req tests

  • removing commented linters

  • removing 1.19 branch from terraform


Co-authored-by: Esteban Ricardo Mirizio [email protected]
Triggered by: push (@buger)
Execution page

@buger
Copy link
Member Author

buger commented Jan 17, 2024

API tests result - postgres15-sha256 env: skipped 🚫
Branch used: refs/heads/release-1.9
Commit: 389f8d3 Merging to release-1.9: TT-10673 Upgrading to Go 1.21 (#766)

TT-10673 Upgrading to Go 1.21 (#766)

  • upgrading to Go 1.21

  • fixing loop issue

  • removing comment

  • linting

  • add release 1.19 revert 1.18 req tests

  • removing commented linters

  • removing 1.19 branch from terraform


Co-authored-by: Esteban Ricardo Mirizio [email protected]
Triggered by: push (@buger)
Execution page

@buger
Copy link
Member Author

buger commented Jan 17, 2024

API tests result - postgres15-murmur64 env: skipped 🚫
Branch used: refs/heads/release-1.9
Commit: 389f8d3 Merging to release-1.9: TT-10673 Upgrading to Go 1.21 (#766)

TT-10673 Upgrading to Go 1.21 (#766)

  • upgrading to Go 1.21

  • fixing loop issue

  • removing comment

  • linting

  • add release 1.19 revert 1.18 req tests

  • removing commented linters

  • removing 1.19 branch from terraform


Co-authored-by: Esteban Ricardo Mirizio [email protected]
Triggered by: push (@buger)
Execution page

@buger
Copy link
Member Author

buger commented Jan 17, 2024

API tests result - mongo44-sha256 env: skipped 🚫
Branch used: refs/heads/release-1.9
Commit: 389f8d3 Merging to release-1.9: TT-10673 Upgrading to Go 1.21 (#766)

TT-10673 Upgrading to Go 1.21 (#766)

  • upgrading to Go 1.21

  • fixing loop issue

  • removing comment

  • linting

  • add release 1.19 revert 1.18 req tests

  • removing commented linters

  • removing 1.19 branch from terraform


Co-authored-by: Esteban Ricardo Mirizio [email protected]
Triggered by: push (@buger)
Execution page

Copy link

sweep-ai bot commented Jan 17, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@buger buger merged commit 389f8d3 into release-1.9 Jan 18, 2024
12 checks passed
@buger buger deleted the merge/release-1.9/e2a7a3ca27c193acdd90b438d52fe8322b4e815e branch January 18, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants