TT-10564 Splunk backoff retry #758
Conversation
…previous failed request
Apply Sweep Rules to your PR?
|
|
API tests result - mongo44-murmur64 env: skipped 🚫 |
|
API tests result - postgres15-sha256 env: skipped 🚫 |
|
API tests result - postgres15-murmur64 env: skipped 🚫 |
|
API tests result - mongo44-sha256 env: skipped 🚫 |
|
/release to release-1.8 |
|
Working on it! Note that it can take a few minutes. |
* splunk backoff retry mechanism to reduce chance of losing logs * only retry for temporary errors * move to separate pkg outside of pumps * set correct collector url * ensure connection can be reused by reading and closing body stream * reset req body to fix error when req body has already been read from previous failed request * tidy up, change retry log to warning as not yet error * add debugging for body bytes sent to splunk & RTT to aid in fine tuning batch size * PR requested changes * fix go linter issue * applying suggested changes * linting --------- Co-authored-by: dominicriordan <[email protected]> Co-authored-by: domsolutions <[email protected]> (cherry picked from commit 35e1e74)
|
@mativm02 Succesfully merged PR |
|
It's merged! Thank you for your contribution @domsolutions, it's really appreciated. |
TT-10564 Splunk backoff retry (#758) * splunk backoff retry mechanism to reduce chance of losing logs * only retry for temporary errors * move to separate pkg outside of pumps * set correct collector url * ensure connection can be reused by reading and closing body stream * reset req body to fix error when req body has already been read from previous failed request * tidy up, change retry log to warning as not yet error * add debugging for body bytes sent to splunk & RTT to aid in fine tuning batch size * PR requested changes * fix go linter issue * applying suggested changes * linting --------- Co-authored-by: dominicriordan <[email protected]> Co-authored-by: domsolutions <[email protected]>
No problem! |
This PR is a duplicated of #745
Introduce an expotential backoff retry mechanism for sending logs to spunk to mitigate the chance of losing logs if pump fails to send logs to spunk (i.e. due to network issue or rate limit being hit). Also fixes bug where pump not closing connections after receiving response. Also spunk responses were not being checked i.e. a
404could be returned and pump would still mark as successful pump export.Description
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet