Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10675 add SQS Pump Backend support #740

Closed

Conversation

masoudhaghbin
Copy link
Contributor

@masoudhaghbin masoudhaghbin commented Nov 13, 2023

Add SQS pump to supported backends

Description

The PR will add the support to pump logs into a SQS instance

Related Issue

#737

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

Copy link

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@masoudhaghbin masoudhaghbin marked this pull request as ready for review November 20, 2023 16:22
@caroltyk caroltyk changed the title add SQS Pump Backend support TT-10675 add SQS Pump Backend support Nov 29, 2023
Copy link
Contributor

@mativm02 mativm02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @masoudhaghbin! Thank you for your contribution, we really appreciate it!
Overall, it looks pretty good. I just left 2 small suggestions.

The only missing points are:

We're looking forward to merging this PR once the suggested changes are addressed. Thank you for your patience!

pumps/sqs.go Outdated Show resolved Hide resolved
pumps/sqs.go Outdated Show resolved Hide resolved
@masoudhaghbin masoudhaghbin requested a review from mativm02 January 6, 2024 15:21
Copy link
Contributor

@mativm02 mativm02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mativm02 mativm02 mentioned this pull request Jan 23, 2024
13 tasks
@mativm02
Copy link
Contributor

@masoudhaghbin I created a duplicated version of this PR with all your commits so CIs can effectively run without complaining about some repo secrets. I'll close this one so we can keep working on the new one and merge it. You can take a look at it here. Again, thank you for your contribution!

@mativm02 mativm02 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants