Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-9476]: add graphstats to analytics record proto #736

Merged
merged 6 commits into from
Oct 30, 2023
Merged

[TT-9476]: add graphstats to analytics record proto #736

merged 6 commits into from
Oct 30, 2023

Conversation

kofoworola
Copy link
Contributor

@kofoworola kofoworola commented Oct 24, 2023 •
edited by jira bot
Loading

Description

We added the graph stats field to the analytics record proto due to an incoming change that let's us have graph analytics without detailed recording, look at Solution2 of this document

TT-9476

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@kofoworola kofoworola force-pushed the feat/pass_graph_stats branch from 0861213 to ebddce4 Compare October 24, 2023 07:02
@sweep-ai
Copy link

sweep-ai bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@kofoworola kofoworola requested a review from mativm02 October 24, 2023 13:42
mativm02
mativm02 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mativm02 mativm02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ - take a look at the golangci linter :)

@kofoworola kofoworola force-pushed the feat/pass_graph_stats branch from f393090 to bbf32ef Compare October 30, 2023 09:17
@kofoworola kofoworola merged commit 9984a1e into master Oct 30, 2023
8 of 9 checks passed
@kofoworola kofoworola deleted the feat/pass_graph_stats branch October 30, 2023 09:46
@kofoworola kofoworola mentioned this pull request Nov 2, 2023
Merged
7 tasks
kofoworola added a commit to TykTechnologies/tyk that referenced this pull request Nov 7, 2023
@kofoworola
[TT-9467]: Added graphstats processing to recorded analytics (#5716)
0f58d07 
<!-- Provide a general summary of your changes in the Title above -->

## Description
This PR makes use of the incoming changes to the pump in this
[PR](TykTechnologies/tyk-pump#736) to allow the
graph pumps to record analytics without the need to enable detailed
recording

[TT-9467](https://tyktech.atlassian.net/browse/TT-9476)
<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


[TT-9467]:
https://tyktech.atlassian.net/browse/TT-9467?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mativm02 mativm02 mativm02 approved these changes

@buraksezer buraksezer buraksezer approved these changes

@pvormste pvormste pvormste approved these changes

@tbuchaillot tbuchaillot Awaiting requested review from tbuchaillot

@rhianeKobar rhianeKobar Awaiting requested review from rhianeKobar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kofoworola @pvormste @buraksezer @mativm02