-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s390x support for pump #704
Conversation
GitHub actions yielded the following error. The command that failed is
There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code. Update the code the changes and avoid modifying the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
Description
This PR adds support for building pump assets for the s390x architecture. It includes modifications to the Dockerfile and the .goreleaser.yml file to enable building for the s390x architecture.
Summary of Changes
ci/Dockerfile.std
to add a new build stage for the s390x architecture. This includes updating the base image to the s390x version, copying necessary files, and running build commands.ci/goreleaser/goreleaser.yml
to add a new build configuration for the s390x architecture. This includes adding a new item in the builds array with the s390x GOARCH value.Please review and merge this PR to enable building pump assets for the s390x architecture.
Fixes #699.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.