Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-13445] Add opa support #350

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[TT-13445] Add opa support #350

merged 4 commits into from
Nov 25, 2024

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Oct 31, 2024

Description

Add ability to turn on OPA rules from the chart directly.

Related Issue

Motivation and Context

Issues with OPA and bootstrapping uncovered this. Default values can help direct the consumer to use the correct config rather than enabling things through extraEnvs

Test Coverage For This Change

Simply run a bootstrap with OPA enabled.
if dashboard.opa.allowAdminPasswordReset is set to true the bootstrap will succeed if not it will fail with an error

You do not have permission to reset the password for other users. As an admin user, this permission can be modified using OPA rules.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner October 31, 2024 13:59
@zalbiraw zalbiraw requested review from olamilekan000 and removed request for a team October 31, 2024 13:59
@zalbiraw zalbiraw changed the title Add opa support [TT-13445] Add opa support Oct 31, 2024
components/tyk-dashboard/values.yaml Outdated Show resolved Hide resolved
tyk-control-plane/values.yaml Outdated Show resolved Hide resolved
tyk-stack/values.yaml Outdated Show resolved Hide resolved
@komalsukhani
Copy link
Collaborator

@zalbiraw Thank you for the contribution. As always PR looks perfect.
I have left minor suggestions. Can you also fix lint errors?

@bojantyk bojantyk merged commit 7f4e7d1 into main Nov 25, 2024
7 checks passed
@bojantyk bojantyk deleted the add-opa-native-support branch November 25, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants