Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-13449 Fixed template name of opentelemetry caFilePath #344

Merged

Conversation

dklenke
Copy link
Contributor

@dklenke dklenke commented Oct 21, 2024

Description

Changes the named template included in the tyk-gateway deployment yaml to the name defined in _helpers.tpl.

Related Issue

Closes #343

Motivation and Context

When setting a custom CA file for opentelemetry with the tyk-gateway helm chart this value was lost.

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dklenke dklenke requested a review from a team as a code owner October 21, 2024 14:19
@dklenke dklenke requested review from komalsukhani and removed request for a team October 21, 2024 14:19
@caroltyk caroltyk changed the title Fixed template name of opentelemetry caFilePath TT-13447 Fixed template name of opentelemetry caFilePath Oct 31, 2024
@caroltyk caroltyk changed the title TT-13447 Fixed template name of opentelemetry caFilePath TT-13449 Fixed template name of opentelemetry caFilePath Oct 31, 2024
@komalsukhani
Copy link
Collaborator

@dklenke Thank you for your contribution! PR looks great.
Can you resolve the lint errors? Just have to remove trailing spaces.

@bojantyk bojantyk merged commit a7cc60a into TykTechnologies:main Nov 5, 2024
6 of 7 checks passed
@dklenke dklenke deleted the bugfix/opentelemetry-ca-file branch November 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small issue with tyk-gateway.gateway.opentelemetry.tls.caFileName
3 participants