Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-13326] - Adds sidecars #336

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[TT-13326] - Adds sidecars #336

merged 3 commits into from
Oct 17, 2024

Conversation

vanny96
Copy link
Contributor

@vanny96 vanny96 commented Oct 8, 2024

Description

Adds the capability of adding sidecars to the gateway pod trough the .gateway.extraContainers field

Related Issue

#335

https://tyktech.atlassian.net/browse/TT-13326

Motivation and Context

As per the issue, it allows to deploy sidecars to the pod. One good example would be GRPC plugins

Test Coverage For This Change

None

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vanny96 vanny96 requested a review from a team as a code owner October 8, 2024 08:20
@vanny96 vanny96 requested review from olamilekan000 and removed request for a team October 8, 2024 08:20
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @vanny96!

Since tyk-gateway is a component chart used by several other charts (tyk-stack, tyk-control-plane, tyk-data-plane, and tyk-oss), we need to ensure that the values.yaml files for each of these charts are updated with the latest configuration you've added related to extraContainers.

Would you mind updating the values.yaml files for the charts I mentioned? This will help maintain consistency across the charts. Feel free to tag me if you have any questions Thanks again!

@vanny96
Copy link
Contributor Author

vanny96 commented Oct 10, 2024

Hey, sure thing, I'll get to it either later today or tomorrow!

@buraksekili
Copy link
Member

hi @vanny96, I believe I expressed myself incorrectly. What I actually meant was that I wanted to add the newly introduced extraContainers configuration to the tyk-gateway section in the values.yaml file of each chart.

For example, at the moment, if we use tyk-stack, we can't configure extraContainers through values.yaml file explicitly unless I know the existence of such a configuration.
Can you please update values.yalm file of the charts (tyk-stack, tyk-control-plane, tyk-data-plane, and tyk-oss) so that values.yalm file of these (for instance, tyk-stack's file, here) include the changes you've added? Let me know if you have any questions. The PR looks great, and i'd like to proceed with merging.

@vanny96
Copy link
Contributor Author

vanny96 commented Oct 17, 2024

Huh, I just interpreted it wrong, you were super clear, I'll get to it and at this point I might add it for everything 😅

@vanny96
Copy link
Contributor Author

vanny96 commented Oct 17, 2024

@buraksekili I think now it should be good! Can you double check it?

@buraksekili
Copy link
Member

looks perfect! i'll hand over the PR to the team for internal testing. thank you for your collaboration!

@buraksekili buraksekili changed the title Adds sidecars [TT-13326] - Adds sidecars Oct 17, 2024
@bojantyk bojantyk merged commit 37d55ac into TykTechnologies:main Oct 17, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants