-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-13326] - Adds sidecars #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @vanny96!
Since tyk-gateway
is a component chart used by several other charts (tyk-stack
, tyk-control-plane
, tyk-data-plane
, and tyk-oss
), we need to ensure that the values.yaml
files for each of these charts are updated with the latest configuration you've added related to extraContainers
.
Would you mind updating the values.yaml
files for the charts I mentioned? This will help maintain consistency across the charts. Feel free to tag me if you have any questions Thanks again!
Hey, sure thing, I'll get to it either later today or tomorrow! |
hi @vanny96, I believe I expressed myself incorrectly. What I actually meant was that I wanted to add the newly introduced For example, at the moment, if we use |
Huh, I just interpreted it wrong, you were super clear, I'll get to it and at this point I might add it for everything 😅 |
@buraksekili I think now it should be good! Can you double check it? |
looks perfect! i'll hand over the PR to the team for internal testing. thank you for your collaboration! |
Description
Adds the capability of adding sidecars to the gateway pod trough the
.gateway.extraContainers
fieldRelated Issue
#335
https://tyktech.atlassian.net/browse/TT-13326
Motivation and Context
As per the issue, it allows to deploy sidecars to the pod. One good example would be GRPC plugins
Test Coverage For This Change
None
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.