Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA-1539] Add step to pick proper branch #364

Merged
merged 19 commits into from
Oct 28, 2024

Conversation

konrad-sol
Copy link
Collaborator

@konrad-sol konrad-sol commented Sep 30, 2024

We need to choose proper test code branch. My proposal implemented in this PR:

  • tyk-analytics repo - just do a checkout of code (github action handle tags, prs and push)
  • tyk repo - we need an extra step that will choose proper branch
  • pump and sink repos - extra step, but without checking tag

This new step will:

  • on tag push trigger checkout the same tag (if tag was created in tyk-analytics repo, will fail otherwise - we want it to fail in this case)
  • on PR it will try to checkout branch with the same name as PR branch, if not - as target branch
  • on push will try to checkout target branch
    If branches are not created in tyk-analytics it will use master.

@konrad-sol konrad-sol requested a review from a team as a code owner September 30, 2024 13:29
@konrad-sol konrad-sol requested a review from ermirizio October 1, 2024 22:23
@konrad-sol konrad-sol requested a review from alephnull October 28, 2024 12:16
@konrad-sol konrad-sol merged commit 8416ee2 into master Oct 28, 2024
11 checks passed
@konrad-sol konrad-sol deleted the QA-1539_proper_test_branch_releng branch October 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants