Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GP -> GPLVM #422

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Rename GP -> GPLVM #422

merged 1 commit into from
Sep 25, 2023

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Sep 25, 2023

The GP tutorial is probably better referred to as a GPLVM tutorial, so I've called it that (I'm planning on adding some more straightforward GP tutorials, so this also free up the GP name for that).

Does updating the name here automatically update the name in the Turing docs, or do I also need to make a PR somewhere else?

@sunxd3
Copy link
Member

sunxd3 commented Sep 25, 2023

Pardon the naivete, what does the LVM part refer to?

@willtebbutt
Copy link
Member Author

"latent variable model" -- I think it discusses this in the tutorial itself :) I would be happy to call it "Gaussian Proess Latent Variable Model" -- it's just a bit of a long name haha

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to change the TOC somewhere @yebai ?

@yebai
Copy link
Member

yebai commented Sep 25, 2023

This file specifies the navigation bar title: https://github.com/TuringLang/turinglang.github.io/blob/master/_data/toc.yml

@yebai
Copy link
Member

yebai commented Sep 25, 2023

@willtebbutt I remember that some parts of this tutorial are disabled; maybe you can try to fix them?

@sunxd3
Copy link
Member

sunxd3 commented Sep 25, 2023

@willtebbutt got it, I think GPLVM is fine for the file name

@willtebbutt
Copy link
Member Author

@willtebbutt I remember that some parts of this tutorial are disabled; maybe you can try to fix them?

At some point. I'd rather keep the scope of this PR to a name change though.

willtebbutt added a commit to TuringLang/turinglang.github.io that referenced this pull request Sep 25, 2023
@willtebbutt
Copy link
Member Author

Okay. So @yebai @torfjelde do we merge this, then merge TuringLang/turinglang.github.io#56 ?

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems good to me!

@willtebbutt willtebbutt merged commit 4482872 into master Sep 25, 2023
@willtebbutt willtebbutt deleted the wct/rename-gp-example branch September 25, 2023 09:55
torfjelde pushed a commit to TuringLang/turinglang.github.io that referenced this pull request Sep 25, 2023
* Update toc.yml

Follow up from TuringLang/docs#422

* Improve title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants