-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename GP -> GPLVM #422
Rename GP -> GPLVM #422
Conversation
Pardon the naivete, what does the |
"latent variable model" -- I think it discusses this in the tutorial itself :) I would be happy to call it "Gaussian Proess Latent Variable Model" -- it's just a bit of a long name haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to change the TOC somewhere @yebai ?
This file specifies the navigation bar title: https://github.com/TuringLang/turinglang.github.io/blob/master/_data/toc.yml |
@willtebbutt I remember that some parts of this tutorial are disabled; maybe you can try to fix them? |
@willtebbutt got it, I think GPLVM is fine for the file name |
At some point. I'd rather keep the scope of this PR to a name change though. |
Follow up from TuringLang/docs#422
Okay. So @yebai @torfjelde do we merge this, then merge TuringLang/turinglang.github.io#56 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems good to me!
* Update toc.yml Follow up from TuringLang/docs#422 * Improve title
The GP tutorial is probably better referred to as a GPLVM tutorial, so I've called it that (I'm planning on adding some more straightforward GP tutorials, so this also free up the GP name for that).
Does updating the name here automatically update the name in the Turing docs, or do I also need to make a PR somewhere else?