Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula API #7

Merged
merged 36 commits into from
Nov 23, 2021
Merged

Formula API #7

merged 36 commits into from
Nov 23, 2021

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Nov 9, 2021

This PR implements the @formula API to TuringGLM, mostly copied from StatsModels.jl and MixedModels.jl.

Note that we are excluding the intercept in the classical StatsModels.jl model matrix construction.

One of #2.

The PR is broken in Julia nighly because of LibTask.jl issues in Julia 1.7

@storopoli storopoli self-assigned this Nov 9, 2021
@storopoli storopoli added the enhancement New feature or request label Nov 9, 2021
@storopoli storopoli added this to the 0.1.0 milestone Nov 9, 2021
Project.toml Show resolved Hide resolved
src/formula.jl Outdated Show resolved Hide resolved
src/turing_model.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9d1b917). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 660ffda differs from pull request most recent head 5bc633b. Consider uploading reports for the commit 5bc633b to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             main      #7   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       1           
  Lines           ?      13           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      13           
  Partials        ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1b917...5bc633b. Read the comment docs.

@storopoli storopoli marked this pull request as ready for review November 22, 2021 20:18
@storopoli
Copy link
Member Author

Ok this PR is getting really big. But the main @formula API is done. Please, whevener you can @rikhuijzer could you review it?

.gitignore Outdated Show resolved Hide resolved
src/contrasts.jl Outdated Show resolved Hide resolved
src/contrasts.jl Outdated Show resolved Hide resolved
src/contrasts.jl Outdated Show resolved Hide resolved
src/contrasts.jl Outdated Show resolved Hide resolved
src/contrasts.jl Outdated Show resolved Hide resolved
src/formula.jl Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@storopoli storopoli enabled auto-merge (squash) November 23, 2021 09:35
@storopoli storopoli disabled auto-merge November 23, 2021 09:40
@storopoli storopoli merged commit c31a978 into main Nov 23, 2021
@storopoli storopoli deleted the formula branch November 23, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants