Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin DifferentiationInterface version #2437

Closed
wants to merge 1 commit into from
Closed

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Dec 13, 2024

This PR pins DifferentiationInterface to < v0.6.24 to avoid Mooncake stack overflow bugs.

cf compintell/Mooncake.jl#416 (comment)

Update: Will says he will make a quick patch for Mooncake to avoid needing this, so we can close this in favour of that when it's ready.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (c0a4ee9) to head (60cbad6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
- Coverage   86.41%   86.28%   -0.13%     
==========================================
  Files          22       22              
  Lines        1575     1575              
==========================================
- Hits         1361     1359       -2     
- Misses        214      216       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 13, 2024

Pull Request Test Coverage Report for Build 12309169585

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+40.4%) to 78.458%

Files with Coverage Reduction New Missed Lines %
src/mcmc/abstractmcmc.jl 2 92.86%
Totals Coverage Status
Change from base Build 12110228665: 40.4%
Covered Lines: 1231
Relevant Lines: 1569

💛 - Coveralls

@penelopeysm penelopeysm changed the title Attempt to pin CI deps Pin DifferentiationInterface version Dec 13, 2024
@penelopeysm
Copy link
Member Author

Closed in favour of Mooncake 0.4.61

@yebai yebai deleted the py/pin-ci-deps branch December 13, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants