DynamicPPL -> 0.29; Julia -> 1.10; Tapir -> Mooncake #2341
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2341 +/- ##
===========================================
+ Coverage 0.00% 86.39% +86.39%
===========================================
Files 22 22
Lines 1533 1573 +40
===========================================
+ Hits 0 1359 +1359
+ Misses 1533 214 -1319 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11466651176Details
💛 - Coveralls |
penelopeysm
changed the title
penelopeysm
force-pushed
the
ch
branch
3 times, most recently
from
787571d to
b7e2369
Compare
penelopeysm
changed the title
|
Tests still aren't passing, there are still a few changes that need to be made to bring it up to date with TuringLang/DynamicPPL.jl#575. I don't mind handling this, but it will take me a long time, so if anybody else feels like expediting it please feel free to jump in:) |
|
I'll ask around if anyone objects to dropping <1.9. |
|
In the meantime I can work to get the PR ready to merge, we will need it at some point anyway whether it's sooner or later:) |
…at) (#2339) Co-authored-by: CompatHelper Julia <[email protected]>
…eep existing compat) (#2340) Co-authored-by: CompatHelper Julia <[email protected]>
vectorize was removed in DynamicPPL 0.29.0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
penelopeysm
changed the title
|
As it turns out, Julia 1.9 won't work either, because SciMLBase. (see e.g. https://github.com/TuringLang/Turing.jl/actions/runs/11153561181/job/31001300867) |
setting a real number as σ is deprecated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Once tests pass (hopefully soon 🙏), still TODO:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
CI is finally passing, so it's time to ask for you all to take a final look! To be honest, there are no major code changes since the last round of reviews. Most of the CI errors were related to upstream issues which have since been fixed (mostly due to @willtebbutt's heroic efforts 🙌 ). Julia 1.11 coming out while this PR was open definitely also made it more fun 😄 There are a few outstanding TODOs which I've opened issues for:
However, this PR makes some sweeping changes to the library. To protect this PR from scope creep, I think we should address these in separate PRs. Notably, all of these issues are about tests, not the library code itself. |
| var .= r | ||
| return var, sum(logpdf_with_trans(dist, r, istrans(vi, vns[1]))), vi | ||
| # Just defer to `SampleFromPrior`. | ||
| retval = DynamicPPL.dot_assume(rng, SampleFromPrior(), dist, vns[1], var, vi) |
There was a problem hiding this comment.
I don't really understand this business with vns being a vector and just getting the first element, or some of the updategid! things. However, since they came from #2360 and were reviewed there, I'm okay with that.
|
Great work. Many thanks, @penelopeysm and all! |
|
great work! thanks guys |
Description
This PR bumps DynamicPPL to 0.29.
Julia
This necessitates dropping support for Julia < 1.10
AutoReverseDiff. DynamicPPL.jl#638)AD backends
Tests
--skip a b c d etook up too much screen width, making it hard to see the other parameters (OS, julia version etc.).Other package version bumps
Compat entries for some other packages have been bumped to take advantage of bug fixes.