Make setadbackend more consistent + use ZygoteRules
#1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
+ Coverage 66.95% 67.01% +0.06%
==========================================
Files 25 25
Lines 1619 1616 -3
==========================================
- Hits 1084 1083 -1
+ Misses 535 533 -2
Continue to review full report at Codecov.
|
bors bot
pushed a commit
to TuringLang/DynamicPPL.jl
that referenced
this pull request
Sep 7, 2020
This PR moves the definition of the adjoint for `updategid!` to DynamicPPL and replaces ZygoteRules with ChainRulesCore, as mentioned in a comment in TuringLang/Turing.jl#1401.
bors bot
pushed a commit
to TuringLang/DynamicPPL.jl
that referenced
this pull request
Sep 7, 2020
This PR moves the definition of the adjoint for `updategid!` to DynamicPPL and replaces ZygoteRules with ChainRulesCore, as mentioned in a comment in TuringLang/Turing.jl#1401.
|
PkgServer lags behind (again)... The new DynamicPPL release is not available in CI yet. Just have to retry until it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency observed in #1400 which leads to different AD settings depending on whether
setadbackend(::Symbol)orsetadbackend(::Val)is called. Moreover, it separates the deprecations into a separate file so that (hopefully) we don't forget to remove them in the next breaking release. Additionally, ZygoteRules is used instead of Zygote inside of a@requireblock, hopefully eliminating potential precompilation and loading time issues for Zygote similar to those observed for ReverseDiff in #1400.