Skip to content

Commit

Permalink
fixed missing merge in initial step for experimental Gibbs
Browse files Browse the repository at this point in the history
  • Loading branch information
torfjelde committed Jul 10, 2024
1 parent 3d3c944 commit e1f1a0e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/experimental/gibbs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ function DynamicPPL.initialstep(
varinfos = map(last, states_and_varinfos)

# Update the base varinfo from the first varinfo and replace it.
varinfos_new = DynamicPPL.setindex!!(varinfos, vi_base, 1)
varinfos_new = DynamicPPL.setindex!!(varinfos, merge(vi_base, first(varinfos)), 1)

Check warning on line 311 in src/experimental/gibbs.jl

View check run for this annotation

Codecov / codecov/patch

src/experimental/gibbs.jl#L311

Added line #L311 was not covered by tests
# Merge the updated initial varinfo with the rest of the varinfos + update the logp.
vi = DynamicPPL.setlogp!!(
reduce(merge, varinfos_new),
Expand Down

0 comments on commit e1f1a0e

Please sign in to comment.