Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing backticks #756

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add missing backticks #756

merged 1 commit into from
Dec 17, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Dec 17, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.94%. Comparing base (8972b98) to head (fed4530).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files          36       36           
  Lines        4276     4276           
=======================================
  Hits         3675     3675           
  Misses        601      601

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12364627968

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 85.39%
Totals Coverage Status
Change from base Build 12358544000: -0.7%
Covered Lines: 3647
Relevant Lines: 4271
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12364627968

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.045%
Totals Coverage Status
Change from base Build 12358544000: 0.0%
Covered Lines: 3675
Relevant Lines: 4271
💛 - Coveralls

yebai
yebai reviewed Dec 17, 2024
View reviewed changes
src/model.jl
@@ -1423,6 +1423,7 @@ julia> model = illegal_likelihood() | (a = 1.0,);
julia> model()
ERROR: ArgumentError: `~` with a model on the right-hand side of an observe statement is not supported
[...]
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this didn't cause doc tests to fail?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - it's just because the whole thing is no longer parsed as a codeblock so it's not a doctest, it's just treated as any other arbitrary text in Markdown.

yebai
yebai approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunxd3!

@yebai yebai added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit 32a5d77 Dec 17, 2024
20 checks passed
@yebai yebai deleted the sunxd/fix_typo branch December 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penelopeysm penelopeysm penelopeysm left review comments

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunxd3 @coveralls @yebai @penelopeysm